webrtc/modules/video_coding/main/source/generic_encoder.h - Issue 1193513006: In screenshare mode, suppress VP8 bitrate overshoot and increase quality

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/modules/video_coding/main/source/generic_encoder.h

Issue 1193513006: In screenshare mode, suppress VP8 bitrate overshoot and increase quality (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc ('k') | webrtc/modules/video_coding/main/source/generic_encoder.cc » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

(...skipping 131 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
142	142

143 private:	143 private:

144 VideoEncoder* const encoder_;	144 VideoEncoder* const encoder_;

145 VideoEncoderRateObserver* const rate_observer_;	145 VideoEncoderRateObserver* const rate_observer_;

146 VCMEncodedFrameCallback* vcm_encoded_frame_callback_;	146 VCMEncodedFrameCallback* vcm_encoded_frame_callback_;

147 uint32_t bit_rate_;	147 uint32_t bit_rate_;

148 uint32_t frame_rate_;	148 uint32_t frame_rate_;

149 const bool internal_source_;	149 const bool internal_source_;

150 mutable rtc::CriticalSection rates_lock_;	150 mutable rtc::CriticalSection rates_lock_;

151 VideoRotation rotation_;	151 VideoRotation rotation_;

	152 bool is_screenshare_;

152 }; // end of VCMGenericEncoder class	153 }; // end of VCMGenericEncoder class

153	154

154 } // namespace webrtc	155 } // namespace webrtc

155	156

156 #endif // WEBRTC_MODULES_VIDEO_CODING_GENERIC_ENCODER_H_	157 #endif // WEBRTC_MODULES_VIDEO_CODING_GENERIC_ENCODER_H_

OLD	NEW