Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: talk/media/webrtc/simulcast.cc

Issue 1193513006: In screenshare mode, suppress VP8 bitrate overshoot and increase quality (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | talk/media/webrtc/webrtcvideoengine2_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2014 Google Inc. 3 * Copyright 2014 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 << codec.simulcastStream[i].maxBitrate << "kbps" 404 << codec.simulcastStream[i].maxBitrate << "kbps"
405 << " with " 405 << " with "
406 << static_cast<int>( 406 << static_cast<int>(
407 codec.simulcastStream[i].numberOfTemporalLayers) 407 codec.simulcastStream[i].numberOfTemporalLayers)
408 << " temporal layers"; 408 << " temporal layers";
409 } 409 }
410 } 410 }
411 411
412 static const int kScreenshareMinBitrateKbps = 50; 412 static const int kScreenshareMinBitrateKbps = 50;
413 static const int kScreenshareMaxBitrateKbps = 6000; 413 static const int kScreenshareMaxBitrateKbps = 6000;
414 static const int kScreenshareDefaultTl0BitrateKbps = 100; 414 static const int kScreenshareDefaultTl0BitrateKbps = 200;
415 static const int kScreenshareDefaultTl1BitrateKbps = 1000; 415 static const int kScreenshareDefaultTl1BitrateKbps = 1000;
416 416
417 static const char* kScreencastLayerFieldTrialName = 417 static const char* kScreencastLayerFieldTrialName =
418 "WebRTC-ScreenshareLayerRates"; 418 "WebRTC-ScreenshareLayerRates";
419 419
420 ScreenshareLayerConfig::ScreenshareLayerConfig(int tl0_bitrate, int tl1_bitrate) 420 ScreenshareLayerConfig::ScreenshareLayerConfig(int tl0_bitrate, int tl1_bitrate)
421 : tl0_bitrate_kbps(tl0_bitrate), tl1_bitrate_kbps(tl1_bitrate) { 421 : tl0_bitrate_kbps(tl0_bitrate), tl1_bitrate_kbps(tl1_bitrate) {
422 } 422 }
423 423
424 ScreenshareLayerConfig ScreenshareLayerConfig::GetDefault() { 424 ScreenshareLayerConfig ScreenshareLayerConfig::GetDefault() {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 ScreenshareLayerConfig config = ScreenshareLayerConfig::GetDefault(); 464 ScreenshareLayerConfig config = ScreenshareLayerConfig::GetDefault();
465 465
466 // For screenshare in conference mode, tl0 and tl1 bitrates are piggybacked 466 // For screenshare in conference mode, tl0 and tl1 bitrates are piggybacked
467 // on the VideoCodec struct as target and max bitrates, respectively. 467 // on the VideoCodec struct as target and max bitrates, respectively.
468 // See eg. webrtc::VP8EncoderImpl::SetRates(). 468 // See eg. webrtc::VP8EncoderImpl::SetRates().
469 codec->targetBitrate = config.tl0_bitrate_kbps; 469 codec->targetBitrate = config.tl0_bitrate_kbps;
470 codec->maxBitrate = config.tl1_bitrate_kbps; 470 codec->maxBitrate = config.tl1_bitrate_kbps;
471 } 471 }
472 472
473 } // namespace cricket 473 } // namespace cricket
OLDNEW
« no previous file with comments | « no previous file | talk/media/webrtc/webrtcvideoengine2_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698