Issue 1192673003: Fix PRESUBMIT.py after disabling CQ.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1192673003: Fix PRESUBMIT.py after disabling CQ. (Closed)

Created:
5 years, 6 months ago by kjellander_webrtc

Modified:
5 years, 6 months ago

Reviewers:
phoglund

CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Fix PRESUBMIT.py after disabling CQ. The disabling of CQ in https://codereview.webrtc.org/1177243003/ broke PRESUBMIT.py since it's trying to read cq.cfg. BUG=501332 TBR=phoglund@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/141725f50fa4223ce2f9e84500971a44d7720c03

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	PRESUBMIT.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kjellander_webrtc

Committed patchset #1 (id:1) manually as 141725f50fa4223ce2f9e84500971a44d7720c03 (presubmit successful).

5 years, 6 months ago (2015-06-18 13:05:45 UTC) #1

tandrii(chromium)

5 years, 6 months ago (2015-06-19 11:59:17 UTC) #3

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1190283003/ by tandrii@chromium.org.

The reason for reverting is: CQ-Rietveld combination now supports webrtc custom
domain..

Expand Messages | Collapse Messages