VP9 wrapper: Adjust speed setting.

VP9 wrapper: Adjust speed setting.

Use lower speed setting for smaller resolutions.

R=stefan@webrtc.org
TBR=stefan@webrtc.org

BUG=

Committed: https://chromium.googlesource.com/external/webrtc/+/6e89b25143b23e19cc2f50f740626f1f4540c1d9

[stefan-webrtc, 2015-06-25 15:26:03]

lgtm

https://codereview.webrtc.org/1192173003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1192173003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:207: int
VP9EncoderImpl::SetCpuSpeed(int width, int height) {
GetCpuSpeed

[stefan-webrtc, 2015-06-25 15:26:50]

https://codereview.webrtc.org/1192173003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1192173003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:207: int
VP9EncoderImpl::SetCpuSpeed(int width, int height) {
On 2015/06/25 15:26:02, stefan-webrtc (holmer) wrote:
> GetCpuSpeed


And actually, please make this a regular function defined at the top of this
file. You shouldn't have to update the header file.

[stefan-webrtc, 2015-06-25 15:27:01]

On 2015/06/25 15:26:50, stefan-webrtc (holmer) wrote:
>
https://codereview.webrtc.org/1192173003/diff/20001/webrtc/modules/video_codi...
> File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):
> 
>
https://codereview.webrtc.org/1192173003/diff/20001/webrtc/modules/video_codi...
> webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:207: int
> VP9EncoderImpl::SetCpuSpeed(int width, int height) {
> On 2015/06/25 15:26:02, stefan-webrtc (holmer) wrote:
> > GetCpuSpeed
> 
> 
> And actually, please make this a regular function defined at the top of this
> file. You shouldn't have to update the header file.

Please look at the nits before committing...

[marpan, 2015-07-07 21:40:55]

Committed patchset #3 (id:40001) manually as
6e89b25143b23e19cc2f50f740626f1f4540c1d9 (presubmit successful).

[tommi, 2015-07-08 09:13:39]

tommi@webrtc.org changed reviewers:
+ tommi@webrtc.org

[tommi, 2015-07-08 09:13:39]

drive-by nits

https://codereview.webrtc.org/1192173003/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (left):

https://codereview.webrtc.org/1192173003/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:226: cpu_speed_ = 7;
cpu_speed_ is in my opinion not a great variable name. For something that
determines quality of the encoding, I would have liked to use something like
encoding_quality_ and define the range in constants (min/max).  As is, cpu_used_
would at least be better since it matches with the vpx settings constant.

https://codereview.webrtc.org/1192173003/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1192173003/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:47: int GetCpuSpeed(int
width, int height) {
Can this be in an anonymous namespace?
Also, I find the function name and parameters to be confusing. :-/
The return value doesn't tell you anything about the speed of the cpu...  where
is the range defined (aside from the comment)?  Would it make sense to call this
GetCompressionQuality or GetEncodingQuality?