Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1191853003:
Add missing include guards for audio_ring_buffer.h. Yikes. (Closed)
|
Created:
5 years, 6 months ago by Andrew MacDonald Modified:
5 years, 6 months ago Reviewers:
aluebs-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, bjornv1, aluebs-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd missing include guards for audio_ring_buffer.h. Yikes.
R=aluebs@webrtc.org
TBR=aluebs@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/2d627a6d5b351e949d45bb5cef1d21e8773995f4
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
andrew@webrtc.org changed reviewers: + aluebs@webrtc.org
The CQ bit was checked by andrew@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191853003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by andrew@webrtc.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191853003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by andrew@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191853003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by andrew@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191853003/1
The CQ bit was unchecked by andrew@webrtc.org
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 2d627a6d5b351e949d45bb5cef1d21e8773995f4 (presubmit successful). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
