Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1190883002: Update deeper codereview.settings files to match the root. (Closed)

Created:
5 years, 6 months ago by Andrew MacDonald
Modified:
5 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc)
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M talk/codereview.settings View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/codereview.settings View 1 chunk +6 lines, -3 lines 0 comments Download
M webrtc/codereview.settings View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Andrew MacDonald
This bit me when I tried to upload from a deeper directory than the root. ...
5 years, 6 months ago (2015-06-17 01:00:07 UTC) #1
Andrew MacDonald
On 2015/06/17 01:00:07, andrew wrote: > This bit me when I tried to upload from ...
5 years, 6 months ago (2015-06-18 15:35:35 UTC) #2
kjellander_webrtc
Thanks! lgtm
5 years, 6 months ago (2015-06-19 07:26:48 UTC) #3
Andrew MacDonald
5 years, 6 months ago (2015-06-24 19:40:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d3e489d01654a4107b99fcfb4ee9ffff9d24d38.

Powered by Google App Engine
This is Rietveld 408576698