Attempt to reland: Allow intelligibility to compile in apm (https://codereview.webrtc.org/118232300…

Attempt to reland: Allow intelligibility to compile in apm (https://codereview.webrtc.org/1182323005/)

Revert of original: https://codereview.webrtc.org/1187033005/

Changes in original:
- Added files to gyp and BUILD
- Made minor fixes to get everything to compile
    and intelligibility_proc to run
- Added comments
- Auto-reformatting

New Changes:
- Added <numeric> header to intelligibility_enhancer.cc to address buildbot errors
- Switched to use WAV for i/o in intelligibility_proc.cc to address windows errors
- clean up

Note: Patch 1 duplicates Patch 7 of https://codereview.webrtc.org/1182323005/

R=andrew@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/db4fecfb01ac51e936e4b7496a4929e713080f07

[ekm, 2015-06-18 19:54:37]

ekmeyerson@webrtc.org changed reviewers:
+ andrew@webrtc.org, turaj@webrtc.org

[Andrew MacDonald, 2015-06-18 23:14:57]

lgtm with minor changes.

https://codereview.webrtc.org/1190733004/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc
(right):

https://codereview.webrtc.org/1190733004/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc:79:
const std::string kTmpOutFile = "tmp_out_file.wav";
Consider using TempFilename for this:
https://cs.corp.google.com/#piper///depot/google3/third_party/webrtc/files/st...

If you do, move it into the scope where it's used.

https://codereview.webrtc.org/1190733004/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc:91:
struct stat in_stat, noise_stat;
Sorry, I meant to delete my comment about these; at first I thought they were
just being used to check if the files were empty, and later realized you wanted
the file size.

Please restore the ASSERTs I asked you to remove :)

[Andrew MacDonald, 2015-06-18 23:16:12]

https://codereview.webrtc.org/1190733004/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc
(right):

https://codereview.webrtc.org/1190733004/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc:79:
const std::string kTmpOutFile = "tmp_out_file.wav";
Whoops, wrong codesearch. I meant:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

[ekm, 2015-06-19 02:02:00]

https://codereview.webrtc.org/1190733004/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc
(right):

https://codereview.webrtc.org/1190733004/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc:79:
const std::string kTmpOutFile = "tmp_out_file.wav";
On 2015/06/18 23:14:57, andrew wrote:
> Consider using TempFilename for this:
>
https://cs.corp.google.com/#piper///depot/google3/third_party/webrtc/files/st...
> 
> If you do, move it into the scope where it's used.

Nice. Done.

https://codereview.webrtc.org/1190733004/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc:91:
struct stat in_stat, noise_stat;
On 2015/06/18 23:14:57, andrew wrote:
> Sorry, I meant to delete my comment about these; at first I thought they were
> just being used to check if the files were empty, and later realized you
wanted
> the file size.
> 
> Please restore the ASSERTs I asked you to remove :)

Done.

[Andrew MacDonald, 2015-06-19 03:59:30]

lgtm with small change

https://codereview.webrtc.org/1190733004/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc
(right):

https://codereview.webrtc.org/1190733004/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc:126:
std::string TempOutFilename =
const std::string temp_out_filename

temp_out_filename since it's not a compile-time const.

[ekm, 2015-06-19 04:11:37]

https://codereview.webrtc.org/1190733004/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc
(right):

https://codereview.webrtc.org/1190733004/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc:126:
std::string TempOutFilename =
On 2015/06/19 03:59:30, andrew wrote:
> const std::string temp_out_filename
> 
> temp_out_filename since it's not a compile-time const.

Done.

[Andrew MacDonald, 2015-06-19 04:19:41]

lgtm++

[ekm, 2015-06-22 21:48:05]

The CQ bit was checked by ekmeyerson@webrtc.org

[commit-bot: I haz the power, 2015-06-22 21:48:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190733004/40001

[commit-bot: I haz the power, 2015-06-22 21:48:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-22 21:48:43]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[ekm, 2015-06-23 00:49:19]

Committed patchset #3 (id:40001) manually as
db4fecfb01ac51e936e4b7496a4929e713080f07 (presubmit successful).