Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1190283003: Revert of Fix PRESUBMIT.py after disabling CQ. (Closed)

Created:
5 years, 6 months ago by tandrii(chromium)
Modified:
5 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix PRESUBMIT.py after disabling CQ. (patchset #1 id:1 of https://codereview.webrtc.org/1192673003/) Reason for revert: CQ-Rietveld combination now supports webrtc custom domain. Original issue's description: > Fix PRESUBMIT.py after disabling CQ. > > The disabling of CQ in https://codereview.webrtc.org/1177243003/ > broke PRESUBMIT.py since it's trying to read cq.cfg. > > BUG=501332 > TBR=phoglund@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/141725f50fa4223ce2f9e84500971a44d7720c03 TBR=phoglund@webrtc.org,kjellander@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501332 Committed: https://crrev.com/04465d286e6a1a643c88fabddd44eb870f906c38 Cr-Commit-Position: refs/heads/master@{#9476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tandrii(chromium)
Created Revert of Fix PRESUBMIT.py after disabling CQ.
5 years, 6 months ago (2015-06-19 11:59:18 UTC) #1
kjellander_webrtc
lgtm
5 years, 6 months ago (2015-06-20 10:53:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190283003/1
5 years, 6 months ago (2015-06-20 11:00:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-20 11:00:53 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-20 11:01:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04465d286e6a1a643c88fabddd44eb870f906c38
Cr-Commit-Position: refs/heads/master@{#9476}

Powered by Google App Engine
This is Rietveld 408576698