Move default trybots configuration to CQ config.

Move default trybots configuration to CQ config.

This is the same set of trybots that used to be configured in PRESUBMIT.py

BUG=470518
TBR=

Committed: https://crrev.com/986ee082b628ffd3a90fbbe4b933a312489921e0
Cr-Commit-Position: refs/heads/master@{#9448}

[kjellander_webrtc, 2015-06-15 19:04:31]

kjellander@webrtc.org changed reviewers:
+ sergiyb@chromium.org

[Sergiy Byelozyorov, 2015-06-15 22:25:55]

lgtm

Btw, did you know that you can keep them synchronized (PRESUBMIT.py can read
them from cq.cfg)? See example here:
https://chromium.googlesource.com/chromium/src/+/master/PRESUBMIT.py#1859

[kjellander_webrtc, 2015-06-16 06:50:27]

On 2015/06/15 at 22:25:55, sergiyb wrote:
> lgtm
> 
> Btw, did you know that you can keep them synchronized (PRESUBMIT.py can read
them from cq.cfg)? See example here:
https://chromium.googlesource.com/chromium/src/+/master/PRESUBMIT.py#1859

No I didn't know that, but I was hoping it would be possible to build something
like that. Great to have it done already! 
I implemented it in PS#2 and edited the CL description a little, so please have
another look.

[Sergiy Byelozyorov, 2015-06-16 09:18:52]

https://codereview.chromium.org/1189583003/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1189583003/diff/20001/PRESUBMIT.py#newcode348
PRESUBMIT.py:348: # Explicitly iterate over copies of keys since we mutate them.
Actually, we are deprecating support for properties and thus need to rewrite
this code to also support list format for builders. I've updated the Chromium
just now, please also replicate the changes there:
https://chromium.googlesource.com/chromium/src/+/master/PRESUBMIT.py#1859

You can just copy-past the new loop.

[kjellander_webrtc, 2015-06-16 09:27:27]

Updated it now.

https://codereview.webrtc.org/1189583003/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1189583003/diff/20001/PRESUBMIT.py#newcode348
PRESUBMIT.py:348: # Explicitly iterate over copies of keys since we mutate them.
On 2015/06/16 at 09:18:52, Sergiy Byelozyorov wrote:
> Actually, we are deprecating support for properties and thus need to rewrite
this code to also support list format for builders. I've updated the Chromium
just now, please also replicate the changes there:
> https://chromium.googlesource.com/chromium/src/+/master/PRESUBMIT.py#1859
> 
> You can just copy-past the new loop.

Thanks. Updated in PS#3.

[Sergiy Byelozyorov, 2015-06-16 09:45:11]

LGTM

[kjellander_webrtc, 2015-06-16 09:46:14]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2015-06-16 09:46:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1189583003/40001

[commit-bot: I haz the power, 2015-06-16 09:46:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 09:46:30]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[kjellander_webrtc, 2015-06-16 09:59:52]

kjellander@webrtc.org changed reviewers:
+ phoglund@webrtc.org

[kjellander_webrtc, 2015-06-16 09:59:52]

+phoglund for full committer review.

[phoglund, 2015-06-16 10:11:31]

https://codereview.webrtc.org/1189583003/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1189583003/diff/40001/PRESUBMIT.py#newcode355
PRESUBMIT.py:355: if 'presubmit' not in builder:
I think this can be written clearer, like

if 'presubmit' in builder:
  # Do not trigger ...
  #
  #
  pass
else:
  try_config[..] =

This gives a bit more focus on the main flow, which is to run tests if the
builder isn't a presubmit builder.

[kjellander_webrtc, 2015-06-16 10:59:49]

PTAL

https://codereview.webrtc.org/1189583003/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1189583003/diff/40001/PRESUBMIT.py#newcode355
PRESUBMIT.py:355: if 'presubmit' not in builder:
On 2015/06/16 at 10:11:31, phoglund2 wrote:
> I think this can be written clearer, like
> 
> if 'presubmit' in builder:
>   # Do not trigger ...
>   #
>   #
>   pass
> else:
>   try_config[..] =
> 
> This gives a bit more focus on the main flow, which is to run tests if the
builder isn't a presubmit builder.

Good idea; I implemented it in PS#4.

[phoglund, 2015-06-16 11:15:32]

lgtm

[kjellander_webrtc, 2015-06-16 11:16:04]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2015-06-16 11:16:04]

The patchset sent to the CQ was uploaded after l-g-t-m from sergiyb@chromium.org
Link to the patchset: https://codereview.webrtc.org/1189583003/#ps60001 (title:
"Addressing comment from phoglund")

[commit-bot: I haz the power, 2015-06-16 11:16:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1189583003/60001

[commit-bot: I haz the power, 2015-06-16 11:16:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 11:16:15]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[kjellander_webrtc, 2015-06-16 11:23:56]

On 2015/06/16 11:16:15, commit-bot: I haz the power wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

I see that it's complaining about committer status still, which is because I
haven't added anyone else than myself to the CQ config yet. I'll do that now
(and TBR= this in the meantime).

[kjellander_webrtc, 2015-06-16 11:24:00]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2015-06-16 11:24:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1189583003/60001

[commit-bot: I haz the power, 2015-06-16 11:32:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-16 11:32:26]

Patchset 4 (id:??) landed as
https://crrev.com/986ee082b628ffd3a90fbbe4b933a312489921e0
Cr-Commit-Position: refs/heads/master@{#9448}