webrtc/base/sslstreamadapter.h - Issue 1189583002: Support generation of EC keys using P256 curve and support ECDSA certs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/sslstreamadapter.h

Issue 1189583002: Support generation of EC keys using P256 curve and support ECDSA certs. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: generalize ssl testing code, misc fixes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/sslstreamadapter.h

diff --git a/webrtc/base/sslstreamadapter.h b/webrtc/base/sslstreamadapter.h

index dcb802972c715c7c6e3d804e82eb8247cdb2bc24..65fe2701a2fb79b9885126f06529f2125fa3283b 100644

--- a/webrtc/base/sslstreamadapter.h

+++ b/webrtc/base/sslstreamadapter.h

@@ -167,7 +167,8 @@ class SSLStreamAdapter : public StreamAdapterInterface {

// Returns the default Ssl cipher used between streams of this class

// for the given protocol version. This is used by the unit tests.

- static std::string GetDefaultSslCipher(SSLProtocolVersion version);

+ static std::string GetDefaultSslCipher(SSLProtocolVersion version,

+ KeyType key_type = KT_DEFAULT);

juberti1 2015/07/03 03:15:19 Default parameters are frowned upon; please add a

torbjorng (webrtc) 2015/07/06 10:11:55 Done. Incidentally, the ssl unit tests use defaul

private:

// If true, the server certificate need not match the configured

« webrtc/base/sslidentity_unittest.cc ('K') | « webrtc/base/sslidentity_unittest.cc ('k') | webrtc/base/sslstreamadapter.cc » ('j') | webrtc/base/sslstreamadapter_unittest.cc » ('J')