talk/app/webrtc/webrtcsession_unittest.cc - Issue 1189583002: Support generation of EC keys using P256 curve and support ECDSA certs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/webrtcsession_unittest.cc

Issue 1189583002: Support generation of EC keys using P256 curve and support ECDSA certs. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: explicitly enable ECDSA for NSS; tolerate ECDSA and RSA certs in unittest Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/webrtcsession_unittest.cc

diff --git a/talk/app/webrtc/webrtcsession_unittest.cc b/talk/app/webrtc/webrtcsession_unittest.cc

index 3a09edab911fc62149a133a24e217f69bfc54047..34adabed3227f55a9e32cce8972222cd31c466bf 100644

--- a/talk/app/webrtc/webrtcsession_unittest.cc

+++ b/talk/app/webrtc/webrtcsession_unittest.cc

@@ -562,7 +562,8 @@ class WebRtcSessionTest : public testing::Test {

desc_factory_->set_secure(cricket::SEC_DISABLED);

std::string identity_name = "WebRTC" +

rtc::ToString(rtc::CreateRandomId());

- identity_.reset(rtc::SSLIdentity::Generate(identity_name));

+ // Confirmed to work with KT_RSA and KT_ECDSA.

+ identity_.reset(rtc::SSLIdentity::Generate(identity_name, rtc::KT_DEFAULT));

tdesc_factory_->set_identity(identity_.get());

tdesc_factory_->set_secure(cricket::SEC_REQUIRED);

}

« no previous file with comments | « talk/app/webrtc/dtlsidentitystore.cc ('k') | talk/app/webrtc/webrtcsessiondescriptionfactory.cc » ('j') | webrtc/base/nssstreamadapter.cc » ('J')