Issue 1188533002: Make global constants 'const'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1188533002: Make global constants 'const' (Closed)

Created:
5 years, 6 months ago by kwiberg-webrtc

Modified:
5 years, 6 months ago

Reviewers:
hlundin-webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, tlegrand-webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -107 lines)			Patch
	M	webrtc/modules/audio_coding/codecs/isac/fix/source/transform_unittest.cc	View	1	1 chunk	+122 lines, -107 lines	0 comments	Download

Total messages: 5 (1 generated)

kwiberg-webrtc

With or without "git cl format"? The formatting isn't that pretty since it left- rather ...

5 years, 6 months ago (2015-06-15 12:24:46 UTC) #3

hlundin-webrtc

I would go without git cl format, since it minimizes the diff. lgtm

5 years, 6 months ago (2015-06-15 12:49:57 UTC) #4

kwiberg-webrtc

5 years, 6 months ago (2015-06-15 13:07:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d10cd97ad31e3d4b348a1e156a52a08b6814b010 (presubmit successful).