Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: talk/app/webrtc/objc/h264decoderfactory.h

Issue 1187573004: iOS HW H264 support. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Unit tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/objc/h264decoderfactory.h
diff --git a/talk/app/webrtc/dtlsidentityservice.cc b/talk/app/webrtc/objc/h264decoderfactory.h
similarity index 67%
copy from talk/app/webrtc/dtlsidentityservice.cc
copy to talk/app/webrtc/objc/h264decoderfactory.h
index b4b7279c8288395a8e23a507f7c78dc199572cab..f24a5a483ed8ba5015d98a749016b592b82c0512 100644
--- a/talk/app/webrtc/dtlsidentityservice.cc
+++ b/talk/app/webrtc/objc/h264decoderfactory.h
@@ -25,26 +25,28 @@
* ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#include "talk/app/webrtc/dtlsidentityservice.h"
+#ifndef TALK_APP_WEBRTC_OBJC_H264_DECODER_FACTORY_H_
+#define TALK_APP_WEBRTC_OBJC_H264_DECODER_FACTORY_H_
-#include "talk/app/webrtc/dtlsidentitystore.h"
-#include "webrtc/base/logging.h"
+#include "talk/media/webrtc/webrtcvideodecoderfactory.h"
+#include "webrtc/base/constructormagic.h"
namespace webrtc {
-bool DtlsIdentityService::RequestIdentity(
- const std::string& identity_name,
- const std::string& common_name,
- webrtc::DTLSIdentityRequestObserver* observer) {
- if (identity_name != DtlsIdentityStore::kIdentityName ||
- common_name != DtlsIdentityStore::kIdentityName) {
- LOG(LS_WARNING) << "DtlsIdentityService::RequestIdentity called with "
- << "unsupported params, identity_name=" << identity_name
- << ", common_name=" << common_name;
- return false;
- }
- store_->RequestIdentity(observer);
- return true;
-}
+// This class is a quick measure for plugging in H264 support and will
+// eventually go away once we build H264 support into the video engine.
pbos-webrtc 2015/06/23 19:13:56 "into the video engine"? Can you not do this now?
tkchin_webrtc 2015/06/24 23:21:13 Done.
+class H264DecoderFactory : public cricket::WebRtcVideoDecoderFactory {
+ public:
+ H264DecoderFactory() {}
+ ~H264DecoderFactory() override {}
+
+ VideoDecoder* CreateVideoDecoder(VideoCodecType type) override;
+ void DestroyVideoDecoder(VideoDecoder* decoder) override;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(H264DecoderFactory);
+};
} // namespace webrtc
+
+#endif // TALK_APP_WEBRTC_OBJC_H264_DECODER_FACTORY_H_

Powered by Google App Engine
This is Rietveld 408576698