Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1186093004: Define uint64 and int64 using long long. (Closed)

Created:
5 years, 6 months ago by kjellander_webrtc
Modified:
5 years, 6 months ago
Reviewers:
tommi, Andrew MacDonald
CC:
tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Define uint64 and int64 using long long. This is to avoid typedef collisions with some compile configurations. For more info, see https://blogs.oracle.com/nike/entry/ilp64_lp64_llp64 http://www.unix.org/whitepapers/64bit.html BUG=webrtc:4497 Committed: https://crrev.com/979e0b30f1a5a8d2d7b7f1f5e9c6bc556b5b909b Cr-Commit-Position: refs/heads/master@{#9451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M webrtc/base/basictypes.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/basictypes_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/base/helpers.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M webrtc/base/nssidentity.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/base/nssstreamadapter.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kjellander_webrtc
tommi; review. andrew: mostly FYI.
5 years, 6 months ago (2015-06-16 11:25:41 UTC) #2
tommi
lgtm
5 years, 6 months ago (2015-06-16 14:12:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186093004/1
5 years, 6 months ago (2015-06-16 14:13:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 14:13:39 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/979e0b30f1a5a8d2d7b7f1f5e9c6bc556b5b909b Cr-Commit-Position: refs/heads/master@{#9451}
5 years, 6 months ago (2015-06-16 14:13:50 UTC) #7
Andrew MacDonald
5 years, 6 months ago (2015-06-16 17:52:47 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698