Change kEchoCancellation to be 'echoCancellation'.

talk/app/webrtc/mediaconstraintsinterface.h

Index: talk/app/webrtc/mediaconstraintsinterface.h
diff --git a/talk/app/webrtc/mediaconstraintsinterface.h b/talk/app/webrtc/mediaconstraintsinterface.h
index 843bee071c44835a7c42de855eb5ca166c810dd4..469a3d3f2d3beb2369d7236d82eb95dd33cc0a74 100644
--- a/talk/app/webrtc/mediaconstraintsinterface.h
+++ b/talk/app/webrtc/mediaconstraintsinterface.h
@@ -72,12 +72,9 @@ class MediaConstraintsInterface {
   static const char kMinFrameRate[];  // minFrameRate
 
   // Constraint keys used by a local audio source.
+  static const char kEchoCancellation[];  // echoCancellation

[Andrew MacDonald, 2015/06/15 04:04:14]

Two concerns here:
1. IIUC, due to this code:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

"googEchoCancellation" will have no effect after your change. This would break
code such as this:
https://webrtc-codereview.appspot.com/53669004/diff/1/talk/examples/android/s...

which uses "googEchoCancellation", no?

2. Chromium treats "echoCancellation" as a flag to disable all audio processing:
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...

which I think is a useful interpretation. We should probably be consistent in
libjingle.

+
   // These keys are google specific.
-  // TODO(tommi): Change kEchoCancellation to be "echoCancellation" once
-  // Chrome has been updated to use kGoogEchoCancellation where the 'goog'
-  // variant is needed.
-  // See https://code.google.com/p/webrtc/issues/detail?id=4747
-  static const char kEchoCancellation[];  // googEchoCancellation
   static const char kGoogEchoCancellation[];  // googEchoCancellation
 
   // TODO(henrik.lundin) Remove kExperimentalEchoCancellation.