Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1184763009: Merge video_engine_core into webrtc target. (Closed)

Created:
5 years, 6 months ago by pbos-webrtc
Modified:
5 years, 6 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Merge video_engine_core into webrtc target. Merges the two video targets since video_engine is no longer usable standalone. BUG=webrtc:1695 R=mflodman@webrtc.org, stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/2ee2439a1f41bd80fa167fb108339f2b535e30a6

Patch Set 1 #

Patch Set 2 : add ratetracker to rtc_base_approved #

Patch Set 3 : remove video_engine.gyp and use video_engine_core_unittests.gyp #

Patch Set 4 : add test common gypi include #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -252 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/base.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/build/apk_tests.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/BUILD.gn View 2 chunks +37 lines, -1 line 0 comments Download
M webrtc/video/webrtc_video.gypi View 1 2 3 chunks +41 lines, -3 lines 0 comments Download
D webrtc/video_engine/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/video_engine/video_engine.gyp View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
D webrtc/video_engine/video_engine_core.gypi View 1 2 3 4 1 chunk +0 lines, -137 lines 0 comments Download
A + webrtc/video_engine/video_engine_core_unittests.gyp View 1 2 3 4 chunks +23 lines, -20 lines 0 comments Download
M webrtc/webrtc.gyp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
pbos-webrtc
add ratetracker to rtc_base_approved
5 years, 6 months ago (2015-06-18 16:40:37 UTC) #1
pbos-webrtc
remove video_engine.gyp and use video_engine_core_unittests.gyp
5 years, 6 months ago (2015-06-18 16:49:14 UTC) #2
pbos-webrtc
add test common gypi include
5 years, 6 months ago (2015-06-18 16:56:43 UTC) #3
pbos-webrtc
rebase
5 years, 6 months ago (2015-06-18 17:02:21 UTC) #4
pbos-webrtc
PTAL
5 years, 6 months ago (2015-06-18 17:05:03 UTC) #6
stefan-webrtc
lgtm
5 years, 6 months ago (2015-06-18 17:11:55 UTC) #7
mflodman
LGTM
5 years, 6 months ago (2015-06-22 04:18:40 UTC) #8
pbos-webrtc
5 years, 6 months ago (2015-06-22 05:57:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
2ee2439a1f41bd80fa167fb108339f2b535e30a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698