Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1184643002: Reland "Upconvert various types to int.", ilbc portion. (Closed)

Created:
5 years, 6 months ago by Peter Kasting
Modified:
5 years, 6 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Upconvert various types to int.", ilbc portion. This reverts portions of commit cb180976dd0e9672cde4523d87b5f4857478b5e9, which reverted commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24. Specifically, the files in webrtc/modules/audio_coding/codecs/ilbc/ are relanded. The original commit message is below: Upconvert various types to int. Per comments from HL/kwiberg on https://webrtc-codereview.appspot.com/42569004 , when there is existing usage of mixed types (int16_t, int, etc.), we'd prefer to standardize on larger types like int and phase out use of int16_t. Specifically, "Using int16 just because we're sure all reasonable values will fit in 16 bits isn't usually meaningful in C." This converts some existing uses of int16_t (and, in a few cases, other types such as uint16_t) to int (or, in a few places, int32_t). Other locations will be converted to size_t in a separate change. BUG=none TBR=kwiberg Committed: https://crrev.com/a8b335c709b244685345cfabb3b72ce672a09d96 Cr-Commit-Position: refs/heads/master@{#9423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -56 lines) Patch
M webrtc/modules/audio_coding/codecs/ilbc/augmented_cb_corr.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/augmented_cb_corr.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy_augmentation.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy_augmentation.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy_calc.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/cb_mem_energy_calc.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/cb_search.c View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/ilbc.c View 4 chunks +19 lines, -19 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/init_decode.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/init_decode.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/init_encode.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/init_encode.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/interface/ilbc.h View 2 chunks +15 lines, -15 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/my_corr.c View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/test/iLBC_testLib.c View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a8b335c709b244685345cfabb3b72ce672a09d96 Cr-Commit-Position: refs/heads/master@{#9423}
5 years, 6 months ago (2015-06-12 01:51:39 UTC) #2
Peter Kasting
Committed patchset #1 (id:1) manually as a8b335c709b244685345cfabb3b72ce672a09d96 (presubmit successful).
5 years, 6 months ago (2015-06-12 01:51:39 UTC) #3
kwiberg-webrtc
5 years, 6 months ago (2015-06-16 19:49:22 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698