Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1184613003: Reland "Upconvert various types to int.", common_audio portion. (Closed)

Created:
5 years, 6 months ago by Peter Kasting
Modified:
5 years, 6 months ago
Reviewers:
Andrew MacDonald
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, bjornv1, aluebs-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Upconvert various types to int.", common_audio portion. This reverts portions of commit cb180976dd0e9672cde4523d87b5f4857478b5e9, which reverted commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24. Specifically, the files in webrtc/common_audio/ are relanded. The original commit message is below: Upconvert various types to int. Per comments from HL/kwiberg on https://webrtc-codereview.appspot.com/42569004 , when there is existing usage of mixed types (int16_t, int, etc.), we'd prefer to standardize on larger types like int and phase out use of int16_t. Specifically, "Using int16 just because we're sure all reasonable values will fit in 16 bits isn't usually meaningful in C." This converts some existing uses of int16_t (and, in a few cases, other types such as uint16_t) to int (or, in a few places, int32_t). Other locations will be converted to size_t in a separate change. BUG=none TBR=andrew Committed: https://crrev.com/15b58eea282b03b6347c64714079691f55e6097f Cr-Commit-Position: refs/heads/master@{#9425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M webrtc/common_audio/signal_processing/cross_correlation.c View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/signal_processing/cross_correlation_mips.c View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/signal_processing/cross_correlation_neon.c View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/signal_processing/include/signal_processing_library.h View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Peter Kasting
Committed patchset #1 (id:1) manually as 15b58eea282b03b6347c64714079691f55e6097f (presubmit successful).
5 years, 6 months ago (2015-06-12 02:41:04 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 02:41:10 UTC) #3
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15b58eea282b03b6347c64714079691f55e6097f
Cr-Commit-Position: refs/heads/master@{#9425}

Powered by Google App Engine
This is Rietveld 408576698