Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1184443005: Remove implicit-int-conversion warnings. (Closed)

Created:
5 years, 6 months ago by pbos-webrtc
Modified:
5 years, 6 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : size_t j #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -51 lines) Patch
M webrtc/video_engine/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/video_engine/overuse_frame_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/report_block_stats.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video_engine/video_engine_core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 4 chunks +44 lines, -25 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M webrtc/video_engine/vie_receiver.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pbos-webrtc
PTAL
5 years, 6 months ago (2015-06-18 15:06:41 UTC) #1
stefan-webrtc
lgtm, but please consider fixing the comment. https://codereview.webrtc.org/1184443005/diff/1/webrtc/video_engine/vie_channel.cc File webrtc/video_engine/vie_channel.cc (right): https://codereview.webrtc.org/1184443005/diff/1/webrtc/video_engine/vie_channel.cc#newcode446 webrtc/video_engine/vie_channel.cc:446: for (int ...
5 years, 6 months ago (2015-06-18 16:56:46 UTC) #2
pbos-webrtc
size_t j
5 years, 6 months ago (2015-06-18 16:59:57 UTC) #3
pbos-webrtc
https://codereview.webrtc.org/1184443005/diff/1/webrtc/video_engine/vie_channel.cc File webrtc/video_engine/vie_channel.cc (right): https://codereview.webrtc.org/1184443005/diff/1/webrtc/video_engine/vie_channel.cc#newcode446 webrtc/video_engine/vie_channel.cc:446: for (int j = static_cast<int>(simulcast_rtp_rtcp_.size()); On 2015/06/18 16:56:46, stefan-webrtc ...
5 years, 6 months ago (2015-06-18 17:00:23 UTC) #4
pbos-webrtc
5 years, 6 months ago (2015-06-18 17:00:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ae37abbf6aa6a660e89256cc86143d6143a0139d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698