Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1182793004: Remove definition of non-existent method. (Closed)

Created:
5 years, 6 months ago by joachim
Modified:
5 years, 6 months ago
Reviewers:
tommi1, juberti1, juberti
CC:
Andrew MacDonald, interface-changes_webrtc.org, niklas.enbom, qiang.lu, rwolff_gocast.it, tterriberry_mozilla.com, webrtc-reviews_webrtc.org, yujie_mao (webrtc)
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove definition of non-existent method. The private method "CreateDefaultLocalDescription" is defined in the class, but not implemented or used anywhere. R=juberti@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/66f920ea57c76e6213ada45ad907872f4fa2e7ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M talk/app/webrtc/webrtcsession.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joachim
PTAL, I think the method was removed at some point in the past but still ...
5 years, 6 months ago (2015-06-18 21:32:44 UTC) #2
joachim
On 2015/06/18 21:32:44, joachim wrote: > PTAL, I think the method was removed at some ...
5 years, 6 months ago (2015-06-22 07:53:48 UTC) #3
joachim
On 2015/06/22 07:53:48, joachim wrote: > On 2015/06/18 21:32:44, joachim wrote: > > PTAL, I ...
5 years, 6 months ago (2015-06-23 00:07:47 UTC) #5
juberti1
lgtm
5 years, 6 months ago (2015-06-24 04:42:40 UTC) #7
joachim
5 years, 6 months ago (2015-06-24 07:34:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
66f920ea57c76e6213ada45ad907872f4fa2e7ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698