Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issue 1182043002: Roll chromium_revision e937e5f..c2239a8 (333350:334133) (Closed)

Created:
5 years, 6 months ago by kjellander_webrtc
Modified:
5 years, 6 months ago
Reviewers:
pbos-webrtc
CC:
Andrew MacDonald, niklas.enbom, qiang.lu, webrtc-reviews_webrtc.org, yujie_mao (webrtc)
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision e937e5f..c2239a8 (333350:334133) Removed no longer used test_isolation_outdir variable as in https://codereview.chromium.org/1176463003 The move of a DEPS in https://codereview.chromium.org/1155743013 is causing problems on some trybots. It shouldn't affect developers. Relevant changes: * src/third_party/android_tools: a3afc68..ed3dde6 * src/third_party/icu: 9939a5d..a05f412 * src/third_party/libjpeg_turbo: 8ee9bdd..f4631b6 * src/third_party/libyuv: 632c50f..632c50f Details: https://chromium.googlesource.com/chromium/src/+/e937e5f..c2239a8/DEPS Clang version was not updated in this roll. BUG= R=pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/05ce5dd0f159c43b50bd87f7faf1fbe8f31d5845

Patch Set 1 #

Patch Set 2 : Removed test_isolation_outdir variable #

Patch Set 3 : Add symllink to third_party/freetype-android #

Patch Set 4 : Trying to satisfy trybots #

Patch Set 5 : Trying new workaround for trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M sync_chromium.py View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M talk/build/isolate.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/build/isolate.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kjellander_webrtc
It seems I found a way to workaround the runhooks issue finally *sigh* It would ...
5 years, 6 months ago (2015-06-15 08:01:42 UTC) #2
pbos-webrtc
git cl patch + gclient sync runs fine. lgtm.
5 years, 6 months ago (2015-06-15 08:56:53 UTC) #3
kjellander_webrtc
5 years, 6 months ago (2015-06-15 09:10:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
05ce5dd0f159c43b50bd87f7faf1fbe8f31d5845 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698