Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Issue 1181693005: Reland remaining bits of "Upconvert various types to int." (Closed)

Created:
5 years, 6 months ago by Peter Kasting
Modified:
5 years, 6 months ago
Reviewers:
Andrew MacDonald
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland remaining bits of "Upconvert various types to int." Most of commit cb180976dd0e9672cde4523d87b5f4857478b5e9 (which reverted commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24) was already re-landed. This relands the rest, including modifications by kwiberg to hopefully avoid regressing performance. In a subsequent change I will see if removing the int16_t cast in this modified version still causes perf problems. BUG=499241 TEST=none TBR=andrew Committed: https://crrev.com/72cfd6c468663a95962d2677c94d91d97b71f980 Cr-Commit-Position: refs/heads/master@{#9487}

Patch Set 1 #

Patch Set 2 : Resync #

Patch Set 3 : Try kwiberg's variations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M webrtc/common_audio/signal_processing/cross_correlation.c View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M webrtc/common_audio/signal_processing/cross_correlation_mips.c View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/signal_processing/cross_correlation_neon.c View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/signal_processing/include/signal_processing_library.h View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181693005/40001
5 years, 6 months ago (2015-06-23 01:26:43 UTC) #3
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-23 02:33:55 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 02:34:08 UTC) #5
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/72cfd6c468663a95962d2677c94d91d97b71f980
Cr-Commit-Position: refs/heads/master@{#9487}

Powered by Google App Engine
This is Rietveld 408576698