Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: talk/media/webrtc/webrtcvideoengine2.cc

Issue 1181653002: Base A/V synchronization on sync_labels. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/webrtc/fakewebrtccall.cc ('k') | talk/media/webrtc/webrtcvideoengine2_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/webrtc/webrtcvideoengine2.cc
diff --git a/talk/media/webrtc/webrtcvideoengine2.cc b/talk/media/webrtc/webrtcvideoengine2.cc
index d33d1909cf65fb1a7a1471ec0ea280d2ada6a509..657475b281dad59f20c67c9219470098b53f5ed0 100644
--- a/talk/media/webrtc/webrtcvideoengine2.cc
+++ b/talk/media/webrtc/webrtcvideoengine2.cc
@@ -1155,15 +1155,8 @@ bool WebRtcVideoChannel2::AddRecvStream(const StreamParams& sp,
webrtc::VideoReceiveStream::Config config;
ConfigureReceiverRtp(&config, sp);
- // Set up A/V sync if there is a VoiceChannel.
- // TODO(pbos): The A/V is synched by the receiving channel. So we need to know
- // the SSRC of the remote audio channel in order to sync the correct webrtc
- // VoiceEngine channel. For now sync the first channel in non-conference to
- // match existing behavior in WebRtcVideoEngine.
- if (voice_channel_id_ != -1 && receive_streams_.empty() &&
- !options_.conference_mode.GetWithDefaultIfUnset(false)) {
- config.audio_channel_id = voice_channel_id_;
- }
+ // Set up A/V sync group based on sync label.
+ config.sync_group = sp.sync_label;
config.rtp.remb = false;
VideoCodecSettings send_codec;
« no previous file with comments | « talk/media/webrtc/fakewebrtccall.cc ('k') | talk/media/webrtc/webrtcvideoengine2_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698