Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: talk/app/webrtc/localaudiosource_unittest.cc

Issue 1181413004: Follow-up: Remove old DelayCorrection AEC config (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/app/webrtc/localaudiosource.cc ('k') | talk/app/webrtc/mediaconstraintsinterface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/localaudiosource_unittest.cc
diff --git a/talk/app/webrtc/localaudiosource_unittest.cc b/talk/app/webrtc/localaudiosource_unittest.cc
index 7e5d8dea678557696ec4e476e69e4e4c095c95b0..62620259b60d7c5858ed6bf6d33f8e554dfb24ae 100644
--- a/talk/app/webrtc/localaudiosource_unittest.cc
+++ b/talk/app/webrtc/localaudiosource_unittest.cc
@@ -78,51 +78,6 @@ TEST(LocalAudioSourceTest, SetValidOptions) {
EXPECT_TRUE(value);
}
-// TODO(henrik.lundin) Remove SetExtendedFilterEchoCancellationOff test.
-// https://code.google.com/p/webrtc/issues/detail?id=4696
-TEST(LocalAudioSourceTest, SetExtendedFilterEchoCancellationOff) {
- webrtc::FakeConstraints constraints;
- constraints.AddOptional(
- MediaConstraintsInterface::kExtendedFilterEchoCancellation, false);
-
- rtc::scoped_refptr<LocalAudioSource> source = LocalAudioSource::Create(
- PeerConnectionFactoryInterface::Options(), &constraints);
-
- bool value;
- EXPECT_TRUE(source->options().extended_filter_aec.Get(&value));
- EXPECT_FALSE(value);
-}
-
-// TODO(henrik.lundin) Remove SetExperimentalEchoCancellationOn test.
-// https://code.google.com/p/webrtc/issues/detail?id=4696
-TEST(LocalAudioSourceTest, SetExperimentalEchoCancellationOn) {
- webrtc::FakeConstraints constraints;
- constraints.AddOptional(
- MediaConstraintsInterface::kExperimentalEchoCancellation, true);
-
- rtc::scoped_refptr<LocalAudioSource> source = LocalAudioSource::Create(
- PeerConnectionFactoryInterface::Options(), &constraints);
-
- bool value;
- EXPECT_TRUE(source->options().extended_filter_aec.Get(&value));
- EXPECT_TRUE(value);
-}
-
-// TODO(henrik.lundin) Remove SetExperimentalEchoCancellationOff test.
-// https://code.google.com/p/webrtc/issues/detail?id=4696
-TEST(LocalAudioSourceTest, SetExperimentalEchoCancellationOff) {
- webrtc::FakeConstraints constraints;
- constraints.AddOptional(
- MediaConstraintsInterface::kExperimentalEchoCancellation, false);
-
- rtc::scoped_refptr<LocalAudioSource> source = LocalAudioSource::Create(
- PeerConnectionFactoryInterface::Options(), &constraints);
-
- bool value;
- EXPECT_TRUE(source->options().extended_filter_aec.Get(&value));
- EXPECT_FALSE(value);
-}
-
TEST(LocalAudioSourceTest, OptionNotSet) {
webrtc::FakeConstraints constraints;
rtc::scoped_refptr<LocalAudioSource> source =
« no previous file with comments | « talk/app/webrtc/localaudiosource.cc ('k') | talk/app/webrtc/mediaconstraintsinterface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698