Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1181413004: Follow-up: Remove old DelayCorrection AEC config (Closed)

Created:
5 years, 6 months ago by hlundin-webrtc
Modified:
5 years, 6 months ago
Reviewers:
tommi, bjornv1
CC:
aluebs-webrtc, Andrew MacDonald, bjornv1, interface-changes_webrtc.org, kwiberg-webrtc, niklas.enbom, qiang.lu, rwolff_gocast.it, tterriberry_mozilla.com, webrtc-reviews_webrtc.org, yujie_mao (webrtc)
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Follow-up: Remove old DelayCorrection AEC config This is a follow-up to r9401, where the configuration DelayCorrection was replaced by ExtendedFilter. This change also removes the media constraint kExperimentalEchoCancellation which was replaced by kExtendedFilterEchoCancellation in the same CL. Both settings that are now being removed were kept in the code to avoid API breakages. In https://codereview.chromium.org/1167343004, depending code has been updated to avoid breakages. BUG=webrtc:4696 R=bjornv@webrtc.org, tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/b02af18c5cb6d6c3def7f44d27a63068360f4f29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -70 lines) Patch
M talk/app/webrtc/localaudiosource.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M talk/app/webrtc/localaudiosource_unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M talk/app/webrtc/mediaconstraintsinterface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/mediaconstraintsinterface.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hlundin-webrtc
Björn, Tommi, Please, review this follow-up to my previous renaming CL. Thanks!
5 years, 6 months ago (2015-06-15 13:44:54 UTC) #2
tommi
lgtm
5 years, 6 months ago (2015-06-15 13:53:14 UTC) #3
bjornv1
lgtm
5 years, 6 months ago (2015-06-15 15:40:53 UTC) #4
hlundin-webrtc
5 years, 6 months ago (2015-06-16 07:53:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b02af18c5cb6d6c3def7f44d27a63068360f4f29 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698