Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: webrtc/common_audio/BUILD.gn

Issue 1181373004: Add a [rtc_]build_with_neon variable to unify conditions. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove gn config and consolidate build_with_neon condition. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/arm.gni") 9 import("//build/config/arm.gni")
10 import("../build/webrtc.gni") 10 import("../build/webrtc.gni")
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 } 123 }
124 } 124 }
125 125
126 if (current_cpu == "arm") { 126 if (current_cpu == "arm") {
127 sources += [ 127 sources += [
128 "signal_processing/complex_bit_reverse_arm.S", 128 "signal_processing/complex_bit_reverse_arm.S",
129 "signal_processing/spl_sqrt_floor_arm.S", 129 "signal_processing/spl_sqrt_floor_arm.S",
130 ] 130 ]
131 131
132 if (arm_version >= 7) { 132 if (arm_version >= 7) {
133 deps += [ ":common_audio_neon" ]
134 sources += [ "signal_processing/filter_ar_fast_q12_armv7.S" ] 133 sources += [ "signal_processing/filter_ar_fast_q12_armv7.S" ]
135 } else { 134 } else {
136 sources += [ "signal_processing/filter_ar_fast_q12.c" ] 135 sources += [ "signal_processing/filter_ar_fast_q12.c" ]
137 } 136 }
138 } 137 }
139 138
140 if (current_cpu == "arm64") { 139 if (rtc_build_with_neon) {
141 deps += [ ":common_audio_neon" ] 140 deps += [ ":common_audio_neon" ]
142 } 141 }
143 142
144 if (current_cpu == "mipsel") { 143 if (current_cpu == "mipsel") {
145 sources += [ 144 sources += [
146 "signal_processing/complex_bit_reverse_mips.c", 145 "signal_processing/complex_bit_reverse_mips.c",
147 "signal_processing/complex_fft_mips.c", 146 "signal_processing/complex_fft_mips.c",
148 "signal_processing/cross_correlation_mips.c", 147 "signal_processing/cross_correlation_mips.c",
149 "signal_processing/downsample_fast_mips.c", 148 "signal_processing/downsample_fast_mips.c",
150 "signal_processing/filter_ar_fast_q12_mips.c", 149 "signal_processing/filter_ar_fast_q12_mips.c",
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 configs += [ "..:common_inherited_config" ] 203 configs += [ "..:common_inherited_config" ]
205 204
206 if (is_clang) { 205 if (is_clang) {
207 # Suppress warnings from Chrome's Clang plugins. 206 # Suppress warnings from Chrome's Clang plugins.
208 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. 207 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
209 configs -= [ "//build/config/clang:find_bad_constructs" ] 208 configs -= [ "//build/config/clang:find_bad_constructs" ]
210 } 209 }
211 } 210 }
212 } 211 }
213 212
214 if (rtc_build_armv7_neon || current_cpu == "arm64") { 213 if (rtc_build_with_neon) {
215 source_set("common_audio_neon") { 214 source_set("common_audio_neon") {
216 sources = [ 215 sources = [
217 "fir_filter_neon.cc", 216 "fir_filter_neon.cc",
218 "resampler/sinc_resampler_neon.cc", 217 "resampler/sinc_resampler_neon.cc",
219 "signal_processing/cross_correlation_neon.c", 218 "signal_processing/cross_correlation_neon.c",
220 "signal_processing/downsample_fast_neon.c", 219 "signal_processing/downsample_fast_neon.c",
221 "signal_processing/min_max_operations_neon.c", 220 "signal_processing/min_max_operations_neon.c",
222 ] 221 ]
223 222
224 configs += [ "..:common_config" ] 223 if (current_cpu != "arm64") {
Andrew MacDonald 2015/06/17 22:46:21 It unfortunately isn't possible to extract these o
225 public_configs = [ "..:common_inherited_config" ] 224 # Enable compilation for the NEON instruction set. This is needed
226 225 # since //build/config/arm.gni only enables NEON for iOS, not Android.
227 if (!arm_use_neon) { 226 # This provides the same functionality as webrtc/build/arm_neon.gypi.
228 configs -= [ "//build/config/compiler:compiler_arm_fpu" ] 227 configs -= [ "//build/config/compiler:compiler_arm_fpu" ]
229 cflags = [ "-mfpu=neon" ] 228 cflags = [ "-mfpu=neon" ]
230 } 229 }
231 230
232 # Disable LTO in audio_processing_neon target due to compiler bug. 231 # Disable LTO due to compiler bug.
233 if (rtc_use_lto) { 232 if (rtc_use_lto) {
234 cflags -= [ 233 cflags -= [
235 "-flto", 234 "-flto",
236 "-ffat-lto-objects", 235 "-ffat-lto-objects",
237 ] 236 ]
238 } 237 }
238
239 configs += [ "..:common_config" ]
240 public_configs = [ "..:common_inherited_config" ]
239 } 241 }
240 } 242 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698