Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: webrtc/build/webrtc.gni

Issue 1181373004: Add a [rtc_]build_with_neon variable to unify conditions. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove gn config and consolidate build_with_neon condition. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/arm.gni") 9 import("//build/config/arm.gni")
10 import("//build/config/mips.gni") 10 import("//build/config/mips.gni")
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 } 98 }
99 99
100 # TODO(ljubomir): Unset rtc_use_openmax_dl for mips64el once mips64el gets 100 # TODO(ljubomir): Unset rtc_use_openmax_dl for mips64el once mips64el gets
101 # supported in GN (since openmax_dl is not supported for mips64el). 101 # supported in GN (since openmax_dl is not supported for mips64el).
102 if (!is_ios && (current_cpu != "arm" || arm_version >= 7)) { 102 if (!is_ios && (current_cpu != "arm" || arm_version >= 7)) {
103 rtc_use_openmax_dl = true 103 rtc_use_openmax_dl = true
104 } else { 104 } else {
105 rtc_use_openmax_dl = false 105 rtc_use_openmax_dl = false
106 } 106 }
107 107
108 # WebRTC builds ARM v7 Neon instruction set optimized code for both iOS and 108 # Determines whether NEON code will be built. It might not be selected at
kjellander_webrtc 2015/06/18 09:06:23 Same comment update as in common.gypi...
Andrew MacDonald 2015/06/25 01:09:09 Done.
109 # Android, which is why we currently cannot use the variables in 109 # run-time.
110 # //build/config/arm.gni (since it disables Neon for Android). 110 rtc_build_with_neon = (current_cpu == "arm" &&
111 rtc_build_armv7_neon = current_cpu == "arm" && arm_version >= 7 111 (arm_use_neon == 1 || arm_optionally_use_neon == 1)) ||
112 current_cpu == "arm64"
112 } 113 }
113 114
114 # Make it possible to provide custom locations for some libraries (move these 115 # Make it possible to provide custom locations for some libraries (move these
115 # up into declare_args should we need to actually use them for the GN build). 116 # up into declare_args should we need to actually use them for the GN build).
116 rtc_libvpx_dir = "//third_party/libvpx" 117 rtc_libvpx_dir = "//third_party/libvpx"
117 rtc_libyuv_dir = "//third_party/libyuv" 118 rtc_libyuv_dir = "//third_party/libyuv"
118 rtc_opus_dir = "//third_party/opus" 119 rtc_opus_dir = "//third_party/opus"
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698