Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1181073002: Reland "Upconvert various types to int.", neteq portion. (Closed)

Created:
5 years, 6 months ago by Peter Kasting
Modified:
5 years, 6 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Upconvert various types to int.", neteq portion. This reverts portions of commit cb180976dd0e9672cde4523d87b5f4857478b5e9, which reverted commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24. Specifically, the files in webrtc/modules/audio_coding/neteq/ are relanded. The original commit message is below: Upconvert various types to int. Per comments from HL/kwiberg on https://webrtc-codereview.appspot.com/42569004 , when there is existing usage of mixed types (int16_t, int, etc.), we'd prefer to standardize on larger types like int and phase out use of int16_t. Specifically, "Using int16 just because we're sure all reasonable values will fit in 16 bits isn't usually meaningful in C." This converts some existing uses of int16_t (and, in a few cases, other types such as uint16_t) to int (or, in a few places, int32_t). Other locations will be converted to size_t in a separate change. BUG=none TBR=kwiberg Committed: https://crrev.com/36b7cc32643bae0379d8102ce05dae82ecc466a1 Cr-Commit-Position: refs/heads/master@{#9427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -46 lines) Patch
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/dsp_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/dsp_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/expand.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/expand.cc View 12 chunks +20 lines, -22 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/merge.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/normal.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/RTPencode.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Peter Kasting
Committed patchset #1 (id:1) manually as 36b7cc32643bae0379d8102ce05dae82ecc466a1 (presubmit successful).
5 years, 6 months ago (2015-06-12 02:57:35 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/36b7cc32643bae0379d8102ce05dae82ecc466a1 Cr-Commit-Position: refs/heads/master@{#9427}
5 years, 6 months ago (2015-06-12 02:57:38 UTC) #3
kwiberg-webrtc
5 years, 6 months ago (2015-06-16 19:43:46 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698