Workaround a (Windows) linker bug when doing a PGO build.

Workaround a (Windows) linker bug when doing a PGO build.

It looks like having a function that ends with "FATAL()" but doesn't also have a return value (even if it's useless).

This is causing a hang in link.exe when doing a PGO build (this has been blocking us from doing PGO builds for more than a month now). See https://connect.microsoft.com/VisualStudio/feedback/details/996802/link-exe-hang-during-the-pgo-optimization-step for more details.
BUG=chromium:491914
R=turaj@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/76eea37ed02f653cc0ca786ece78c358e7544db2

[Sébastien Marchand, 2015-06-18 21:24:46]

sebmarchand@chromium.org changed reviewers:
+ henrik.lundin@webrtc.org, scottmg@chromium.org

[Sébastien Marchand, 2015-06-18 21:24:53]

PTAL.

[turaj, 2015-06-19 15:33:21]

turaj@webrtc.org changed reviewers:
+ turaj@webrtc.org

[turaj, 2015-06-19 15:33:22]

LGTM after considering the comment.

https://codereview.webrtc.org/1181033009/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc (right):

https://codereview.webrtc.org/1181033009/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc:275: return
-1;
Please add a comment for the need of "return -1" after FATAL();

[Sébastien Marchand, 2015-06-19 15:59:30]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2015-06-19 15:59:31]

The patchset sent to the CQ was uploaded after l-g-t-m from turaj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1181033009/#ps20001 (title:
"Add a comment.")

[Sébastien Marchand, 2015-06-19 16:01:33]

Thanks, committing.

https://codereview.webrtc.org/1181033009/diff/1/webrtc/modules/audio_coding/m...
File webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc (right):

https://codereview.webrtc.org/1181033009/diff/1/webrtc/modules/audio_coding/m...
webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc:275: return
-1;
On 2015/06/19 15:33:22, turaj wrote:
> Please add a comment for the need of "return -1" after FATAL();

Done.

[niklas.enbom, 2015-06-19 16:11:17]

Committed patchset #2 (id:20001) manually as
76eea37ed02f653cc0ca786ece78c358e7544db2 (presubmit successful).