Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1180673009: Fix WebRTC window-capture to check for maximized state correctly. (Closed)

Created:
5 years, 6 months ago by Peter Kasting
Modified:
5 years, 6 months ago
Reviewers:
Wez
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, jiayl, Sergey Ulanov
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix WebRTC window-capture to check for maximized state correctly. The SW_SHOWXXX values are not bitfields, so using "&" is incorrect. BUG=none TEST=Verify that Chrome's WebRTC window-capture feature can capture an unoccluded, non-maximized window correctly under Windows 8 or above. R=wez@chromium.org Committed: https://crrev.com/7faba36f79c1cc8f8715f1060b849fdb5fcd6629 Cr-Commit-Position: refs/heads/master@{#9421}

Patch Set 1 #

Patch Set 2 : Accidentally deleted my original branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/desktop_capture/win/window_capture_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Peter Kasting
I've split this out to a separate change so it's easier to test and/or revert. ...
5 years, 6 months ago (2015-06-11 20:06:40 UTC) #2
Wez
Adding jiayl@ & sergeyu@ to CC FTI. FWIW, the check at https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc/modules/desktop_capture/cropping_window_capturer_win.cc&sq=package:chromium&l=125 means that this ...
5 years, 6 months ago (2015-06-11 22:24:08 UTC) #3
Peter Kasting
Committed patchset #2 (id:20001) manually as 7faba36f79c1cc8f8715f1060b849fdb5fcd6629 (presubmit successful).
5 years, 6 months ago (2015-06-11 22:43:16 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 22:43:17 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7faba36f79c1cc8f8715f1060b849fdb5fcd6629
Cr-Commit-Position: refs/heads/master@{#9421}

Powered by Google App Engine
This is Rietveld 408576698