Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1179983003: disable MacAsyncSocketTest::TestConnectFailIPv6 (Closed)

Created:
5 years, 6 months ago by minyue-webrtc
Modified:
5 years, 6 months ago
CC:
tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

disable MacAsyncSocketTest::TestConnectFailIPv6 BUG=webrtc:4738 R=kjellander@webrtc.org TBR=tommi@webrtc.org Committed: https://crrev.com/524f78456cbb99ac09eaf00a67fb7ec60dbb3b04 Cr-Commit-Position: refs/heads/master@{#9439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/base/macsocketserver_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
minyue-webrtc
Hi Henrik, This is to disable a flacky test.
5 years, 6 months ago (2015-06-15 13:50:28 UTC) #2
kjellander_webrtc
lgtm
5 years, 6 months ago (2015-06-15 13:52:30 UTC) #3
minyue-webrtc
On 2015/06/15 13:52:30, kjellander (webrtc) wrote: > lgtm ping Tommi for owner's approval.
5 years, 6 months ago (2015-06-15 13:58:30 UTC) #5
minyue-webrtc
On 2015/06/15 13:58:30, minyuel wrote: > On 2015/06/15 13:52:30, kjellander (webrtc) wrote: > > lgtm ...
5 years, 6 months ago (2015-06-15 14:02:26 UTC) #6
minyue-webrtc
Committed patchset #1 (id:1) manually as 524f78456cbb99ac09eaf00a67fb7ec60dbb3b04 (presubmit successful).
5 years, 6 months ago (2015-06-15 14:04:03 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 14:04:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/524f78456cbb99ac09eaf00a67fb7ec60dbb3b04
Cr-Commit-Position: refs/heads/master@{#9439}

Powered by Google App Engine
This is Rietveld 408576698