webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc - Issue 1179953003: Revert "Upconvert various types to int."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc

Issue 1179953003: Revert "Upconvert various types to int." (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc

diff --git a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc

index 1eeb5caa9f53795989d2ae38d5bfba7d136c7cd0..c05d773c0293952d11931e8d67c90b3e00be1a46 100644

--- a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc

+++ b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc

@@ -198,7 +198,7 @@ AudioEncoder::EncodedInfo AudioEncoderOpus::EncodeInternal(

CHECK_EQ(input_buffer_.size(),

static_cast<size_t>(num_10ms_frames_per_packet_) *

samples_per_10ms_frame_);

- int status = WebRtcOpus_Encode(

+ int16_t status = WebRtcOpus_Encode(

inst_, &input_buffer_[0],

rtc::CheckedDivExact(CastInt16(input_buffer_.size()),

static_cast<int16_t>(num_channels_)),