Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 1179093003: Reland "Upconvert various types to int.", misc. codecs portion. (Closed)

Created:
5 years, 6 months ago by Peter Kasting
Modified:
5 years, 6 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Upconvert various types to int.", misc. codecs portion. This reverts portions of commit cb180976dd0e9672cde4523d87b5f4857478b5e9, which reverted commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24. Specifically, the files in webrtc/modules/audio_coding/codecs/ that are not in ilbc/ or isac/, as well as webrtc/modules/audio_coding/main/test/opus_test.cc, are relanded. The original commit message is below: Upconvert various types to int. Per comments from HL/kwiberg on https://webrtc-codereview.appspot.com/42569004 , when there is existing usage of mixed types (int16_t, int, etc.), we'd prefer to standardize on larger types like int and phase out use of int16_t. Specifically, "Using int16 just because we're sure all reasonable values will fit in 16 bits isn't usually meaningful in C." This converts some existing uses of int16_t (and, in a few cases, other types such as uint16_t) to int (or, in a few places, int32_t). Other locations will be converted to size_t in a separate change. BUG=none TBR=kwiberg Committed: https://crrev.com/bba780707848ad36066739c60d7b28cd752fb92f Cr-Commit-Position: refs/heads/master@{#9424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -60 lines) Patch
M webrtc/modules/audio_coding/codecs/cng/include/webrtc_cng.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/webrtc_cng.c View 4 chunks +10 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/g722_interface.c View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/include/g722_interface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/interface/opus_interface.h View 4 chunks +13 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_fec_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_interface.c View 4 chunks +13 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/opus_test.cc View 1 chunk +5 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Peter Kasting
Committed patchset #1 (id:1) manually as bba780707848ad36066739c60d7b28cd752fb92f (presubmit successful).
5 years, 6 months ago (2015-06-12 02:03:05 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bba780707848ad36066739c60d7b28cd752fb92f Cr-Commit-Position: refs/heads/master@{#9424}
5 years, 6 months ago (2015-06-12 02:03:07 UTC) #3
kwiberg-webrtc
5 years, 6 months ago (2015-06-16 19:47:24 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698