Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1179093002: Reland "Upconvert various types to int.", isac portion. (Closed)

Created:
5 years, 6 months ago by Peter Kasting
Modified:
5 years, 6 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Upconvert various types to int.", isac portion. This reverts portions of commit cb180976dd0e9672cde4523d87b5f4857478b5e9, which reverted commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24. Specifically, the files in webrtc/modules/audio_coding/codecs/isac/ are relanded. The original commit message is below: Upconvert various types to int. Per comments from HL/kwiberg on https://webrtc-codereview.appspot.com/42569004 , when there is existing usage of mixed types (int16_t, int, etc.), we'd prefer to standardize on larger types like int and phase out use of int16_t. Specifically, "Using int16 just because we're sure all reasonable values will fit in 16 bits isn't usually meaningful in C." This converts some existing uses of int16_t (and, in a few cases, other types such as uint16_t) to int (or, in a few places, int32_t). Other locations will be converted to size_t in a separate change. BUG=none TBR=kwiberg Committed: https://crrev.com/aba07ef6d92bf1ded7ad1af49b54a8e6652dfcbb Cr-Commit-Position: refs/heads/master@{#9422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -137 lines) Patch
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/interface/audio_encoder_isacfix.h View 3 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/interface/isacfix.h View 5 chunks +16 lines, -16 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_logist.c View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routins.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/codec.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/decode.c View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/isacfix.c View 10 chunks +24 lines, -24 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/test/test_iSACfixfloat.c View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/interface/audio_encoder_isac.h View 3 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/interface/isac.h View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/crc.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/crc.c View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/isac.c View 10 chunks +31 lines, -31 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/isac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/test/SwitchingSampRate/SwitchingSampRate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/test/simpleKenny.c View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Peter Kasting
Committed patchset #1 (id:1) manually as aba07ef6d92bf1ded7ad1af49b54a8e6652dfcbb (presubmit successful).
5 years, 6 months ago (2015-06-12 01:19:45 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aba07ef6d92bf1ded7ad1af49b54a8e6652dfcbb Cr-Commit-Position: refs/heads/master@{#9422}
5 years, 6 months ago (2015-06-12 01:19:48 UTC) #3
kwiberg-webrtc
5 years, 6 months ago (2015-06-16 19:34:22 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698