Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1178943007: Improve Android HW decoder error handling. (Closed)

Created:
5 years, 6 months ago by AlexG
Modified:
5 years, 6 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Improve Android HW decoder error handling. - Remove an option to use MediaCodec SW decoder from Java layer. - Better handling Java exceptions in JNI - detect exceptions and either try to reset the codec or fallback to SW decoder. - If any error is reported by codec try to fallback to SW codec for VP8 or reset decoder and continue decoding for H.264. - Add more logging for error conditions. R=wzh@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/782671f7983e27be865f04f546fbfc3f1cb4e1b3

Patch Set 1 #

Patch Set 2 : Revert logging back to normal. #

Patch Set 3 : Remove copy paste error. #

Patch Set 4 : Alway clear message Q in Release() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -76 lines) Patch
M talk/app/webrtc/java/jni/androidmediacodeccommon.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/jni/androidmediadecoder_jni.cc View 1 2 3 22 chunks +117 lines, -68 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
AlexG
PTAL
5 years, 6 months ago (2015-06-12 22:49:29 UTC) #2
wzh
lgtm
5 years, 6 months ago (2015-06-12 22:57:09 UTC) #3
AlexG
Committed patchset #4 (id:60001) manually as 782671f7983e27be865f04f546fbfc3f1cb4e1b3 (presubmit successful).
5 years, 6 months ago (2015-06-12 23:40:57 UTC) #4
zjx20
On 2015/06/12 22:49:29, AlexG wrote: > PTAL One question: Is it still support SW H264 ...
5 years, 6 months ago (2015-06-15 02:40:56 UTC) #5
AlexG
5 years, 6 months ago (2015-06-15 17:54:38 UTC) #6
Message was sent while issue was closed.
On 2015/06/15 02:40:56, zhoujianxiong2 wrote:
> On 2015/06/12 22:49:29, AlexG wrote:
> > PTAL
> 
> One question: Is it still support SW H264 codec after applying this patch?
> I am not very clear since webrtc doesn't have a builtin SW H264 codec.
> Thanks!

No, SW H.264 is not supported yet - WebRTC on Android supports only HW H.264 and
only on Qualcomm platfroms for now. In this patch if error happens when using
H.264 HW codec then an attempt is made to restart Hw decoder instead of falling
back to SW.

Powered by Google App Engine
This is Rietveld 408576698