New FileSystemURL cracking

webkit/chromeos/fileapi/cros_mount_point_provider_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/chromeos/fileapi/cros_mount_point_provider.h"
 
 #include <set>
 
 #include "base/file_path.h"
 #include "googleurl/src/url_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/fileapi/external_mount_points.h"
 #include "webkit/fileapi/file_system_url.h"
 #include "webkit/fileapi/isolated_context.h"
 #include "webkit/quota/mock_special_storage_policy.h"
 
 #define FPL(x) FILE_PATH_LITERAL(x)
 
+using fileapi::ExternalMountPoints;
+using fileapi::FileSystemURL;
+
 namespace {
 
-fileapi::FileSystemURL CreateFileSystemURL(const std::string& extension,
-                                           const char* path) {
-  return fileapi::FileSystemURL(GURL("chrome-extension://" + extension + "/"),
-                                fileapi::kFileSystemTypeNativeLocal,
-                                FilePath::FromUTF8Unsafe(path));
+FileSystemURL CreateFileSystemURL(const std::string& extension,
+                                  const char* path,
+                                  ExternalMountPoints* mount_points) {
+  return mount_points->CreateCrackedFileSystemURL(
+      GURL("chrome-extension://" + extension + "/"),
+      fileapi::kFileSystemTypeExternal,
+      FilePath::FromUTF8Unsafe(path));
 }
 
 TEST(CrosMountPointProviderTest, DefaultMountPoints) {
   scoped_refptr<quota::SpecialStoragePolicy> storage_policy =
       new quota::MockSpecialStoragePolicy();
   scoped_refptr<fileapi::ExternalMountPoints> mount_points(
       fileapi::ExternalMountPoints::CreateRefCounted());
   chromeos::CrosMountPointProvider provider(
       storage_policy,
       mount_points.get(),
@@ skipping 157 matching lines @@
   // Initialize mount points.
   system_mount_points->RegisterFileSystem("system",
                                           fileapi::kFileSystemTypeNativeLocal,
                                           FilePath(FPL("/g/system")));
   ASSERT_TRUE(provider.AddLocalMountPoint(FilePath(FPL("/media/removable"))));
   ASSERT_TRUE(provider.AddRestrictedLocalMountPoint(
       FilePath(FPL("/usr/share/oem"))));
 
   // Provider specific mount point access.
   EXPECT_FALSE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "removable/foo")));
+      CreateFileSystemURL(extension, "removable/foo", mount_points.get())));
 
   provider.GrantFileAccessToExtension(extension,
                                       FilePath(FPL("removable/foo")));
   EXPECT_TRUE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "removable/foo")));
+      CreateFileSystemURL(extension, "removable/foo", mount_points.get())));
   EXPECT_FALSE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "removable/foo1")));
+      CreateFileSystemURL(extension, "removable/foo1", mount_points.get())));
 
   // System mount point access.
   EXPECT_FALSE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "system/foo")));
+      CreateFileSystemURL(extension, "system/foo", system_mount_points.get())));
 
   provider.GrantFileAccessToExtension(extension, FilePath(FPL("system/foo")));
   EXPECT_TRUE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "system/foo")));
-  EXPECT_FALSE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "system/foo1")));
+      CreateFileSystemURL(extension, "system/foo", system_mount_points.get())));
+  EXPECT_FALSE(provider.IsAccessAllowed(CreateFileSystemURL(
+      extension, "system/foo1", system_mount_points.get())));
 
   // oem is restricted file system.
   provider.GrantFileAccessToExtension(extension, FilePath(FPL("oem/foo")));
   // The extension should not be able to access the file even if
   // GrantFileAccessToExtension was called.
   EXPECT_FALSE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "oem/foo")));
+      CreateFileSystemURL(extension, "oem/foo", mount_points.get())));
 
   provider.GrantFullAccessToExtension(extension);
   // The extension should be able to access restricted file system after it was
   // granted full access.
   EXPECT_TRUE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "oem/foo")));
+      CreateFileSystemURL(extension, "oem/foo", mount_points.get())));
   // The extension which was granted full access  should be able to access any
-  // path on current file systems.
+  // path on curent file systems.
   EXPECT_TRUE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "removable/foo1")));
-  EXPECT_TRUE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "system/foo1")));
+      CreateFileSystemURL(extension, "removable/foo1", mount_points.get())));
+  EXPECT_TRUE(provider.IsAccessAllowed(CreateFileSystemURL(
+      extension, "system/foo1", system_mount_points.get())));
 
-  // The extension still cannot access new mount points.
+  // The extension cannot access new mount points.
+  // TODO(tbarzic): This should probably be changed.
   ASSERT_TRUE(provider.AddLocalMountPoint(FilePath(FPL("/foo/test"))));
   EXPECT_FALSE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "test_/foo")));
+      CreateFileSystemURL(extension, "test_/foo", mount_points.get())));
 
   provider.RevokeAccessForExtension(extension);
   EXPECT_FALSE(provider.IsAccessAllowed(
-      CreateFileSystemURL(extension, "removable/foo")));
+      CreateFileSystemURL(extension, "removable/foo", mount_points.get())));
 
-  fileapi::FileSystemURL internal_url(GURL("chrome://foo"),
-                                      fileapi::kFileSystemTypeExternal,
-                                      FilePath(FPL("removable/")));
+  fileapi::FileSystemURL internal_url = FileSystemURL::CreateForTest(
+      GURL("chrome://foo"),
+      fileapi::kFileSystemTypeExternal,
+      FilePath(FPL("removable/")));
   // Internal WebUI should have full access.
   EXPECT_TRUE(provider.IsAccessAllowed(internal_url));
 }
 
 TEST(CrosMountPointProvider, GetVirtualPathConflictWithSystemPoints) {
   scoped_refptr<quota::MockSpecialStoragePolicy> storage_policy =
       new quota::MockSpecialStoragePolicy();
   scoped_refptr<fileapi::ExternalMountPoints> mount_points(
       fileapi::ExternalMountPoints::CreateRefCounted());
   scoped_refptr<fileapi::ExternalMountPoints> system_mount_points(
@@ skipping 53 matching lines @@
       continue;
 
     FilePath expected_virtual_path(kTestCases[i].virtual_path);
     EXPECT_EQ(expected_virtual_path, virtual_path)
         << "Resolving " << kTestCases[i].local_path;
   }
 }
 
 }  // namespace