Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1178643006: VideoCapturerAndroid: Add possibility to request a new resolution from the video adapter. (Closed)

Created:
5 years, 6 months ago by åsapersson
Modified:
5 years, 6 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid: Add possibility to request a new resolution from the video adapter. BUG= R=glaznev@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/2b679250fbd50b3c8d9ac266a42fbc8a1bd84167

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : added log message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 chunk +3 lines, -0 lines 0 comments Download
M talk/app/webrtc/androidvideocapturer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M talk/app/webrtc/androidvideocapturer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.h View 2 chunks +2 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.cc View 1 3 chunks +28 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java View 1 2 4 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
åsapersson
5 years, 6 months ago (2015-06-12 13:43:40 UTC) #2
AlexG
lgtm https://codereview.webrtc.org/1178643006/diff/20001/talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java File talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java (right): https://codereview.webrtc.org/1178643006/diff/20001/talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java#newcode663 talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java:663: } suggest to add log message for this ...
5 years, 6 months ago (2015-06-13 00:13:53 UTC) #3
åsapersson
https://codereview.webrtc.org/1178643006/diff/20001/talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java File talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java (right): https://codereview.webrtc.org/1178643006/diff/20001/talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java#newcode663 talk/app/webrtc/java/src/org/webrtc/VideoCapturerAndroid.java:663: } On 2015/06/13 00:13:53, AlexG wrote: > suggest to ...
5 years, 6 months ago (2015-06-15 07:13:38 UTC) #4
åsapersson
5 years, 6 months ago (2015-06-15 07:53:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
2b679250fbd50b3c8d9ac266a42fbc8a1bd84167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698