webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc - Issue 1178053002: Add UMA logging for target audio bitrate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc

Issue 1178053002: Add UMA logging for target audio bitrate (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixing a problem that was revealed in tests, and silencing a few warnings Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc ('k') | webrtc/modules/audio_coding/main/acm2/codec_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc

diff --git a/webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc b/webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc

index 183d526ffc3ce2d694ab02286a06514c2a094a8e..568ae1ebe7f1de840ced89fc9d1ab93a55f2d19f 100644

--- a/webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc

+++ b/webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc

@@ -1564,6 +1564,10 @@ TEST_F(AcmSenderBitExactnessOldApi, External_Pcmu_20ms) {

.Times(AtLeast(1))

.WillRepeatedly(

Invoke(&encoder, &AudioEncoderMutablePcmU::EncodeInternal));

+ EXPECT_CALL(mock_encoder, GetTargetBitrate())

+ .Times(AtLeast(1))

+ .WillRepeatedly(Invoke(

+ &encoder, &AudioEncoderMutablePcmU::GetTargetBitrate));

ASSERT_NO_FATAL_FAILURE(

SetUpTestExternalEncoder(&mock_encoder, codec_inst.pltype));

Run("81a9d4c0bb72e9becc43aef124c981e9", "8f9b8750bd80fe26b6cbf6659b89f0f9",