iSAC: Move global trig tables into the codec instance

webrtc/modules/audio_coding/codecs/isac/main/source/intialize.c

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 22 matching lines @@
   }
   for (k = 0; k < ORDERHI+1; k++) {
     maskdata->CorrBufHi[k] = 0.0;
     maskdata->PreStateHiF[k] = 0.0;
     maskdata->PreStateHiG[k] = 0.0;
     maskdata->PostStateHiF[k] = 0.0;
     maskdata->PostStateHiG[k] = 0.0;
   }
 
   maskdata->OldEnergy = 10.0;
-
-  /* fill tables for transforms */
-  WebRtcIsac_InitTransform();
-

[the sun, 2015/06/15 15:08:51]

I don't know this code. What about the stuff above? Would that be subject to the
same race issues?

[kwiberg-webrtc, 2015/06/15 21:57:28]

No, because it operates on per-instance data.

   return;
 }
 
 void WebRtcIsac_InitPreFilterbank(PreFiltBankstr *prefiltdata)
 {
   int k;
 
   for (k = 0; k < QLOOKAHEAD; k++) {
     prefiltdata->INLABUF1[k] = 0;
     prefiltdata->INLABUF2[k] = 0;
@@ skipping 109 matching lines @@
     State->whitened_buf[k] = 0.0;
   for (k = 0; k < QLOOKAHEAD; k++)
     State->inbuf[k] = 0.0;
 
   WebRtcIsac_InitPitchFilter(&(State->PFstr_wght));
 
   WebRtcIsac_InitPitchFilter(&(State->PFstr));
 
   WebRtcIsac_InitWeightingFilter(&(State->Wghtstr));
 }