webrtc/modules/audio_processing/ns/noise_suppression.c - Issue 1175903002: audio_processing: Create now returns a pointer to the object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/ns/noise_suppression.c

Issue 1175903002: audio_processing: Create now returns a pointer to the object (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_processing/ns/include/noise_suppression_x.h ('K') | « webrtc/modules/audio_processing/ns/include/noise_suppression_x.h ('k') | webrtc/modules/audio_processing/ns/noise_suppression_x.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/ns/noise_suppression.c

diff --git a/webrtc/modules/audio_processing/ns/noise_suppression.c b/webrtc/modules/audio_processing/ns/noise_suppression.c

index 0efbebcc4ec513c73a9744d2b62f28ad559c137e..cdecd6273266996572af7676ddba028bdb14f491 100644

--- a/webrtc/modules/audio_processing/ns/noise_suppression.c

+++ b/webrtc/modules/audio_processing/ns/noise_suppression.c

@@ -17,15 +17,10 @@

#include "webrtc/modules/audio_processing/ns/defines.h"

#include "webrtc/modules/audio_processing/ns/ns_core.h"

-int WebRtcNs_Create(NsHandle** NS_inst) {

- *NS_inst = (NsHandle*)malloc(sizeof(NoiseSuppressionC));

- if (*NS_inst != NULL) {

- (*(NoiseSuppressionC**)NS_inst)->initFlag = 0;

- return 0;

- } else {

- return -1;

- }

+NsHandle* WebRtcNs_Create() {

+ NoiseSuppressionC* self = malloc(sizeof(NoiseSuppressionC));

kwiberg-webrtc 2015/06/10 09:31:43 See? No cast.

+ self->initFlag = 0;

+ return (NsHandle*)self;

}

void WebRtcNs_Free(NsHandle* NS_inst) {