Chromium Code Reviews| Index: webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc |
| diff --git a/webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc b/webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc |
| index 6c325e0c518174c16a6b7cd83b7c938772169503..30c362014097f30691e70ef34319a5f11e4a8b50 100644 |
| --- a/webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc |
| +++ b/webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc |
| @@ -20,22 +20,20 @@ extern "C" { |
| } |
| #include "testing/gtest/include/gtest/gtest.h" |
| +#include "webrtc/base/checks.h" |
| namespace webrtc { |
| TEST(EchoCancellationTest, CreateAndFreeHasExpectedBehavior) { |
| - EXPECT_EQ(-1, WebRtcAec_Create(NULL)); |
| - void* handle = NULL; |
| - ASSERT_EQ(0, WebRtcAec_Create(&handle)); |
| - EXPECT_TRUE(handle != NULL); |
| + void* handle = WebRtcAec_Create(); |
| + CHECK(handle != nullptr); |
|
kwiberg-webrtc
2015/06/10 09:31:43
This is in a test, so
ASSERT_TRUE(handle);
?
bjornv1
2015/06/10 19:03:04
Done
|
| WebRtcAec_Free(nullptr); |
| WebRtcAec_Free(handle); |
| } |
| TEST(EchoCancellationTest, ApplyAecCoreHandle) { |
| - void* handle = NULL; |
| - ASSERT_EQ(0, WebRtcAec_Create(&handle)); |
| - EXPECT_TRUE(handle != NULL); |
| + void* handle = WebRtcAec_Create(); |
| + CHECK(handle != nullptr); |
|
kwiberg-webrtc
2015/06/10 09:31:43
Same.
bjornv1
2015/06/10 19:03:04
Done
|
| EXPECT_TRUE(WebRtcAec_aec_core(NULL) == NULL); |
| AecCore* aec_core = WebRtcAec_aec_core(handle); |
| EXPECT_TRUE(aec_core != NULL); |