Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Issue 1175243003: Remove webrtc/libjingle/{examples,session}. (Closed)

Created:
5 years, 6 months ago by pbos-webrtc
Modified:
5 years, 6 months ago
Reviewers:
juberti1, pthatcher1
CC:
tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove webrtc/libjingle/{examples,session}. webrtc/libjingle/ is deprecated and these targets (unlike xmllite/xmpp) are not currently in use in Chromium (which blocks removing the whole webrtc/libjingle/ folder). BUG= R=juberti@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/f5642913c9b11e1b3b24ba20b5c696dd48b9d37f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20021 lines) Patch
D webrtc/libjingle/examples/call/Info.plist View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/libjingle/examples/call/call_main.cc View 1 chunk +0 lines, -484 lines 0 comments Download
D webrtc/libjingle/examples/call/call_unittest.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/libjingle/examples/call/callclient.h View 1 chunk +0 lines, -352 lines 0 comments Download
D webrtc/libjingle/examples/call/callclient.cc View 1 chunk +0 lines, -1617 lines 0 comments Download
D webrtc/libjingle/examples/call/callclient_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/libjingle/examples/call/console.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/libjingle/examples/call/console.cc View 1 chunk +0 lines, -169 lines 0 comments Download
D webrtc/libjingle/examples/call/friendinvitesendtask.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/libjingle/examples/call/friendinvitesendtask.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D webrtc/libjingle/examples/call/mediaenginefactory.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/libjingle/examples/call/mediaenginefactory.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D webrtc/libjingle/examples/call/muc.h View 1 chunk +0 lines, -66 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinviterecvtask.h View 1 chunk +0 lines, -82 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinviterecvtask.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinvitesendtask.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/libjingle/examples/call/mucinvitesendtask.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/libjingle/examples/call/presencepushtask.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/libjingle/examples/call/presencepushtask.cc View 1 chunk +0 lines, -222 lines 0 comments Download
D webrtc/libjingle/examples/login/login_main.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M webrtc/libjingle/libjingle.gyp View 1 chunk +0 lines, -159 lines 0 comments Download
D webrtc/libjingle/session/constants.h View 1 chunk +0 lines, -219 lines 0 comments Download
D webrtc/libjingle/session/constants.cc View 1 chunk +0 lines, -217 lines 0 comments Download
D webrtc/libjingle/session/media/call.h View 1 chunk +0 lines, -308 lines 0 comments Download
D webrtc/libjingle/session/media/call.cc View 1 chunk +0 lines, -1134 lines 0 comments Download
D webrtc/libjingle/session/media/mediamessages.h View 1 chunk +0 lines, -98 lines 0 comments Download
D webrtc/libjingle/session/media/mediamessages.cc View 1 chunk +0 lines, -332 lines 0 comments Download
D webrtc/libjingle/session/media/mediamessages_unittest.cc View 1 chunk +0 lines, -363 lines 0 comments Download
D webrtc/libjingle/session/media/mediasessionclient.h View 1 chunk +0 lines, -175 lines 0 comments Download
D webrtc/libjingle/session/media/mediasessionclient.cc View 1 chunk +0 lines, -1160 lines 0 comments Download
D webrtc/libjingle/session/media/mediasessionclient_unittest.cc View 1 chunk +0 lines, -3324 lines 0 comments Download
D webrtc/libjingle/session/p2ptransportparser.h View 1 chunk +0 lines, -67 lines 0 comments Download
D webrtc/libjingle/session/p2ptransportparser.cc View 1 chunk +0 lines, -216 lines 0 comments Download
D webrtc/libjingle/session/parsing.h View 1 chunk +0 lines, -140 lines 0 comments Download
D webrtc/libjingle/session/parsing.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D webrtc/libjingle/session/rawtransportparser.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/libjingle/session/rawtransportparser.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D webrtc/libjingle/session/session_unittest.cc View 1 chunk +0 lines, -2430 lines 0 comments Download
D webrtc/libjingle/session/sessionclient.h View 1 chunk +0 lines, -80 lines 0 comments Download
D webrtc/libjingle/session/sessionmanager.h View 1 chunk +0 lines, -436 lines 0 comments Download
D webrtc/libjingle/session/sessionmanager.cc View 1 chunk +0 lines, -1150 lines 0 comments Download
D webrtc/libjingle/session/sessionmanagertask.h View 1 chunk +0 lines, -76 lines 0 comments Download
D webrtc/libjingle/session/sessionmessages.h View 1 chunk +0 lines, -219 lines 0 comments Download
D webrtc/libjingle/session/sessionmessages.cc View 1 chunk +0 lines, -1132 lines 0 comments Download
D webrtc/libjingle/session/sessionsendtask.h View 1 chunk +0 lines, -128 lines 0 comments Download
D webrtc/libjingle/session/transportparser.h View 1 chunk +0 lines, -78 lines 0 comments Download
D webrtc/libjingle/session/transportparser.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D webrtc/libjingle/session/transportparser_unittest.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D webrtc/libjingle/session/tunnel/pseudotcpchannel.h View 1 chunk +0 lines, -140 lines 0 comments Download
D webrtc/libjingle/session/tunnel/pseudotcpchannel.cc View 1 chunk +0 lines, -605 lines 0 comments Download
D webrtc/libjingle/session/tunnel/securetunnelsessionclient.h View 1 chunk +0 lines, -165 lines 0 comments Download
D webrtc/libjingle/session/tunnel/securetunnelsessionclient.cc View 1 chunk +0 lines, -397 lines 0 comments Download
D webrtc/libjingle/session/tunnel/tunnelsessionclient.h View 1 chunk +0 lines, -182 lines 0 comments Download
D webrtc/libjingle/session/tunnel/tunnelsessionclient.cc View 1 chunk +0 lines, -432 lines 0 comments Download
D webrtc/libjingle/session/tunnel/tunnelsessionclient_unittest.cc View 1 chunk +0 lines, -226 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pbos-webrtc
PTAL, pthatcher@ asked me to create this CL, so you can probably sync on your ...
5 years, 6 months ago (2015-06-11 09:22:07 UTC) #1
juberti1
On 2015/06/11 at 09:22:07, pbos wrote: > PTAL, pthatcher@ asked me to create this CL, ...
5 years, 6 months ago (2015-06-11 18:18:28 UTC) #2
pbos-webrtc
5 years, 6 months ago (2015-06-12 11:13:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5642913c9b11e1b3b24ba20b5c696dd48b9d37f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698