webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc - Issue 1174813003: Prepare to convert various types to size_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc

Issue 1174813003: Prepare to convert various types to size_t. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Review comments + resync Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc

diff --git a/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc b/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc

index effb4058f4d6ac853104e9823186e8150b96eb62..8e10dffe8e88ed5e7100b9eb350338db7015a9a0 100644

--- a/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc

+++ b/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc

@@ -24,7 +24,8 @@ const int kSampleRateHz = 16000;

} // namespace

bool AudioEncoderG722::Config::IsOk() const {

- return (frame_size_ms % 10 == 0) && (num_channels >= 1);

+ return (frame_size_ms > 0) && (frame_size_ms % 10 == 0) &&

+ (num_channels >= 1);

}

AudioEncoderG722::EncoderState::EncoderState() {