webrtc/common_audio/signal_processing/dot_product_with_scale.c - Issue 1174813003: Prepare to convert various types to size_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_audio/signal_processing/dot_product_with_scale.c

Issue 1174813003: Prepare to convert various types to size_t. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Review comments + resync Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/common_audio/signal_processing/dot_product_with_scale.c

diff --git a/webrtc/common_audio/signal_processing/dot_product_with_scale.c b/webrtc/common_audio/signal_processing/dot_product_with_scale.c

index 389bcf0578f7895520335835e86d9820e4370340..c01ec57309ec32809e0e3305ebc40246e2a9766c 100644

--- a/webrtc/common_audio/signal_processing/dot_product_with_scale.c

+++ b/webrtc/common_audio/signal_processing/dot_product_with_scale.c

@@ -18,7 +18,7 @@ int32_t WebRtcSpl_DotProductWithScale(const int16_t* vector1,

int i = 0;

/* Unroll the loop to improve performance. */

- for (i = 0; i < length - 3; i += 4) {

+ for (i = 0; i + 3 < length; i += 4) {

sum += (vector1[i + 0] * vector2[i + 0]) >> scaling;

sum += (vector1[i + 1] * vector2[i + 1]) >> scaling;

sum += (vector1[i + 2] * vector2[i + 2]) >> scaling;