Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1173523003: Auto-roll script: Add dirty tree check and git pull (Closed)

Created:
5 years, 6 months ago by kjellander_webrtc
Modified:
5 years, 6 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Auto-roll script: Add dirty tree check and git pull BUG=4688 R=pbos@webrtc.org Committed: https://crrev.com/1b76ca121ed820495b3ae238e06df0728b42ece9 Cr-Commit-Position: refs/heads/master@{#9399}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added treecheck and made pull not run in dry-run mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M tools/autoroller/roll_chromium_revision.py View 1 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
kjellander_webrtc
5 years, 6 months ago (2015-06-09 09:26:35 UTC) #2
pbos-webrtc
https://codereview.webrtc.org/1173523003/diff/1/tools/autoroller/roll_chromium_revision.py File tools/autoroller/roll_chromium_revision.py (right): https://codereview.webrtc.org/1173523003/diff/1/tools/autoroller/roll_chromium_revision.py#newcode302 tools/autoroller/roll_chromium_revision.py:302: _RunCommand(['git', 'pull']) Do you want to do this under ...
5 years, 6 months ago (2015-06-09 09:34:32 UTC) #3
kjellander_webrtc
I added a dirty tree check and updated according to your comment. https://codereview.webrtc.org/1173523003/diff/1/tools/autoroller/roll_chromium_revision.py File tools/autoroller/roll_chromium_revision.py ...
5 years, 6 months ago (2015-06-09 10:51:04 UTC) #4
pbos-webrtc
lgtm
5 years, 6 months ago (2015-06-09 10:57:26 UTC) #5
kjellander_webrtc
Committed patchset #2 (id:20001) manually as 1b76ca121ed820495b3ae238e06df0728b42ece9 (presubmit successful).
5 years, 6 months ago (2015-06-09 10:59:00 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 10:59:08 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b76ca121ed820495b3ae238e06df0728b42ece9
Cr-Commit-Position: refs/heads/master@{#9399}

Powered by Google App Engine
This is Rietveld 408576698