Issue 1173253008: Unit Test For VCMReceiver::FrameForDecoding Timing Test

Issue 1173253008: Unit Test For VCMReceiver::FrameForDecoding Timing Test (Closed)

Created:
5 years, 6 months ago by qiangchen

Modified:
5 years, 6 months ago

Reviewers:
wtc, Stefan

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Resolved Rebase Conflicts This is just https://webrtc-codereview.appspot.com/53629004/ Remove a constructor of VCMJitterBuffer. Remove unnecessary factory use Comment Fix Move frame incoming simulation to the clock DCHECK typo fix Coding Style Fix Rephrased some comments, and removed some virtual for override function. Coding Style Fix Coding Style Fix Add a unittest for VCMReceiver::FrameForDecoding. Mainly test the time control algorithm. BUG= TBR=holmer@chromium.org Committed: https://chromium.googlesource.com/external/webrtc/+/d4cec15c75fd554764c9b7b969331943265fcc59

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+252 lines, -14 lines)			Patch
M	webrtc/modules/video_coding/main/source/jitter_buffer.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webrtc/modules/video_coding/main/source/jitter_buffer.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	webrtc/modules/video_coding/main/source/jitter_buffer_unittest.cc	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	webrtc/modules/video_coding/main/source/receiver.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	webrtc/modules/video_coding/main/source/receiver.cc	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	webrtc/modules/video_coding/main/source/receiver_unittest.cc	View	3 chunks	+213 lines, -2 lines	0 comments	Download
M	webrtc/modules/video_coding/main/source/test/stream_generator.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	webrtc/modules/video_coding/main/source/test/stream_generator.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173253008/1

5 years, 6 months ago (2015-06-17 21:06:30 UTC) #3

qiangchen

5 years, 6 months ago (2015-06-19 16:17:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d4cec15c75fd554764c9b7b969331943265fcc59 (presubmit successful).