Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: talk/app/webrtc/dtlsidentitystore.h

Issue 1171893003: Adding DCHECKs and constness to DtlsIdentityStore. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Address comments and add more const Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/dtlsidentitystore.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2015 Google Inc. 3 * Copyright 2015 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 class WorkerTask; 72 class WorkerTask;
73 typedef rtc::ScopedMessageData<DtlsIdentityStore::WorkerTask> 73 typedef rtc::ScopedMessageData<DtlsIdentityStore::WorkerTask>
74 IdentityTaskMessageData; 74 IdentityTaskMessageData;
75 75
76 void GenerateIdentity(); 76 void GenerateIdentity();
77 void OnIdentityGenerated(rtc::scoped_ptr<rtc::SSLIdentity> identity); 77 void OnIdentityGenerated(rtc::scoped_ptr<rtc::SSLIdentity> identity);
78 void ReturnIdentity(rtc::scoped_ptr<rtc::SSLIdentity> identity); 78 void ReturnIdentity(rtc::scoped_ptr<rtc::SSLIdentity> identity);
79 79
80 void PostGenerateIdentityResult_w(rtc::scoped_ptr<rtc::SSLIdentity> identity); 80 void PostGenerateIdentityResult_w(rtc::scoped_ptr<rtc::SSLIdentity> identity);
81 81
82 rtc::Thread* signaling_thread_; 82 rtc::Thread* const signaling_thread_;
83 rtc::Thread* worker_thread_; 83 rtc::Thread* const worker_thread_;
84 84
85 // These members should be accessed on the signaling thread only. 85 // These members should be accessed on the signaling thread only.
86 int pending_jobs_; 86 int pending_jobs_;
87 rtc::scoped_ptr<rtc::SSLIdentity> free_identity_; 87 rtc::scoped_ptr<rtc::SSLIdentity> free_identity_;
88 typedef std::queue<rtc::scoped_refptr<webrtc::DTLSIdentityRequestObserver>> 88 typedef std::queue<rtc::scoped_refptr<webrtc::DTLSIdentityRequestObserver>>
89 ObserverList; 89 ObserverList;
90 ObserverList pending_observers_; 90 ObserverList pending_observers_;
91 }; 91 };
92 92
93 } // namespace webrtc 93 } // namespace webrtc
94 94
95 #endif // TALK_APP_WEBRTC_DTLSIDENTITYSTORE_H_ 95 #endif // TALK_APP_WEBRTC_DTLSIDENTITYSTORE_H_
OLDNEW
« no previous file with comments | « no previous file | talk/app/webrtc/dtlsidentitystore.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698