Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1171793002: Rename targets to use lower case format. (Closed)

Created:
5 years, 6 months ago by tkchin_webrtc
Modified:
5 years, 6 months ago
CC:
hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename targets to use lower case format. It makes writing a build script for merging libraries across architectures easier. See talk/build/build_ios_libs.sh. BUG= R=andrew@webrtc.org, kjellander@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/786dbdcc38f51ea0b32cc34de17e88dfdfea2fb5

Patch Set 1 #

Patch Set 2 : Rename iSAC to isac. #

Total comments: 3

Patch Set 3 : Rename rest of mixed cased targets. #

Patch Set 4 : Alphabetize dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -84 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/audio_coding_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/cng.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/g711.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/g722.gypi View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/ilbc.gypi View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isac.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isac_test.gypi View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isacfix.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/isacfix_test.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module.gypi View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.gypi View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_tests.gypi View 1 2 3 13 chunks +38 lines, -38 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
tkchin_webrtc
5 years, 6 months ago (2015-06-08 22:54:10 UTC) #2
Andrew MacDonald
Please change the original target name to isac rather than proliferating the non-conforming name :)
5 years, 6 months ago (2015-06-08 23:01:58 UTC) #3
tkchin_webrtc
On 2015/06/08 23:01:58, andrew wrote: > Please change the original target name to isac rather ...
5 years, 6 months ago (2015-06-08 23:14:08 UTC) #4
Andrew MacDonald
On 2015/06/08 23:14:08, tkchin_webrtc wrote: > On 2015/06/08 23:01:58, andrew wrote: > > Please change ...
5 years, 6 months ago (2015-06-08 23:26:57 UTC) #5
tkchin_webrtc
Updated.
5 years, 6 months ago (2015-06-09 00:10:41 UTC) #6
kjellander_webrtc
lgtm, but you'll get bonus points if you rename the last ones. I don't think ...
5 years, 6 months ago (2015-06-09 06:27:38 UTC) #7
Andrew MacDonald
lgtm with kjellander's changes.
5 years, 6 months ago (2015-06-09 07:40:24 UTC) #8
tkchin_webrtc
On 2015/06/09 at 07:40:24, andrew wrote: > lgtm with kjellander's changes. Going for the bonus ...
5 years, 6 months ago (2015-06-09 20:51:42 UTC) #9
Andrew MacDonald
On 2015/06/09 20:51:42, tkchin_webrtc wrote: > On 2015/06/09 at 07:40:24, andrew wrote: > > lgtm ...
5 years, 6 months ago (2015-06-09 22:28:50 UTC) #10
tkchin_webrtc
5 years, 6 months ago (2015-06-10 20:45:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
786dbdcc38f51ea0b32cc34de17e88dfdfea2fb5.

Powered by Google App Engine
This is Rietveld 408576698