Disable reduced-size RTCP in default config.

Disable reduced-size RTCP in default config.

Verifies that reduced-size isn't configured in WebRtcVideoEngine2
without explicit configuration (which doesn't exist). Also disables REMB
in the default config because it requires reconfiguration.

Adds default-config tests to make sure that they don't contain
parameters that need to be negotiated between clients.

BUG=chromium:497103, webrtc:4745
R=mflodman@webrtc.org, stefan@webrtc.org

Committed: https://crrev.com/d7da120b40f7a8a8357f23cf6b49aa03f67c1cf6
Cr-Commit-Position: refs/heads/master@{#9384}

[pbos-webrtc, 2015-06-05 11:25:12]

PTAL, we should get this in ASAP to request a merge into M44.

[mflodman, 2015-06-05 11:50:03]

Prod-filer LG, but I'd like to change the loopback test to turn on REMB and NACK
since this is the proposed configuration.

https://codereview.webrtc.org/1171533002/diff/1/webrtc/video/end_to_end_tests.cc
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/1171533002/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:2807: TEST_F(EndToEndTest,
DefaultSendConfigDoesNotContainExtensions) {
I'd prefer another name than Extensions, since this does more than that. Maybe
something around verification of default packets? Or RTP?

[pbos-webrtc, 2015-06-05 11:50:15]

add remb to BitrateEstimatorTest and Loopback

[mflodman, 2015-06-05 11:54:30]

LGTM with name discussed offline.

[mflodman, 2015-06-05 11:54:32]

LGTM with name discussed offline.

[pbos-webrtc, 2015-06-05 11:54:42]

rename tests

[stefan-webrtc, 2015-06-05 11:56:28]

lgtm, but consider moving that remb = true somewhere else.

https://codereview.webrtc.org/1171533002/diff/20001/webrtc/test/call_test.cc
File webrtc/test/call_test.cc (right):

https://codereview.webrtc.org/1171533002/diff/20001/webrtc/test/call_test.cc#...
webrtc/test/call_test.cc:111: config.rtp.remb = true;
This is just to always have remb enabled in tests? It doesn't seem like a
"matching" thing.

[pbos-webrtc, 2015-06-05 12:01:30]

https://codereview.webrtc.org/1171533002/diff/20001/webrtc/test/call_test.cc
File webrtc/test/call_test.cc (right):

https://codereview.webrtc.org/1171533002/diff/20001/webrtc/test/call_test.cc#...
webrtc/test/call_test.cc:111: config.rtp.remb = true;
On 2015/06/05 11:56:28, stefan1 wrote:
> This is just to always have remb enabled in tests? It doesn't seem like a
> "matching" thing.

Considered, though I don't think there's any good place to put it since it's not
"matching" the sender config (no remb config in sender).

[pbos-webrtc, 2015-06-05 12:01:56]

https://codereview.webrtc.org/1171533002/diff/1/webrtc/video/end_to_end_tests.cc
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/1171533002/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:2807: TEST_F(EndToEndTest,
DefaultSendConfigDoesNotContainExtensions) {
On 2015/06/05 11:50:03, mflodman wrote:
> I'd prefer another name than Extensions, since this does more than that. Maybe
> something around verification of default packets? Or RTP?

Done.

[pbos-webrtc, 2015-06-05 12:09:53]

Committed patchset #3 (id:40001) manually as
d7da120b40f7a8a8357f23cf6b49aa03f67c1cf6 (presubmit successful).

[commit-bot: I haz the power, 2015-06-05 12:09:58]

Patchset 3 (id:??) landed as
https://crrev.com/d7da120b40f7a8a8357f23cf6b49aa03f67c1cf6
Cr-Commit-Position: refs/heads/master@{#9384}