Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1171033002: Ensures that modules_unittests runs on iOS (Closed)

Created:
5 years, 6 months ago by henrika_webrtc
Modified:
5 years, 6 months ago
Reviewers:
tkchin, tkchin_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -83 lines) Patch
M webrtc/modules/audio_coding/codecs/cng/cng_unittest.cc View 11 chunks +12 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/isac_unittest.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_unittest.cc View 13 chunks +16 lines, -15 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest.cc View 2 chunks +13 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_classifier_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc View 6 chunks +8 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/time_stretch_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/agc/histogram_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/agc/pitch_based_vad_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/agc/standalone_vad_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/transient/file_utils_unittest.cc View 14 chunks +16 lines, -13 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_detector_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/transient/wpd_tree_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/media_file/source/media_file_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/utility/source/file_player_unittests.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_sender_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/main/test/unit_test/brightness_detection_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/main/test/unit_test/content_metrics_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/main/test/unit_test/deflickering_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/main/test/unit_test/video_processing_unittest.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M webrtc/test/testsupport/gtest_disable.h View 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
henrika_webrtc
Output from modules_unittests with this patch: [==========] 1125 tests from 159 test cases ran. (63208 ...
5 years, 6 months ago (2015-06-09 14:40:07 UTC) #2
tkchin
lovely :) Excited to get this all up and running on bots. lgtm https://codereview.chromium.org/1171033002/diff/1/webrtc/modules/audio_coding/neteq/neteq_unittest.cc File ...
5 years, 6 months ago (2015-06-09 17:50:23 UTC) #4
henrika_webrtc
Done. Thanks. Let's hope these tests will work well on the iOS bots. https://codereview.chromium.org/1171033002/diff/1/webrtc/modules/audio_coding/neteq/neteq_unittest.cc File ...
5 years, 6 months ago (2015-06-10 08:48:48 UTC) #5
henrika_webrtc
5 years, 6 months ago (2015-06-10 11:25:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a2c79405b407162119954d57855c8c04c043df76 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698